Removing the mutation in the factories for getting dep repositories

appengine/findit/common/test/chrome_dependency_fetcher_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 import collections
 
 from testing_utils import testing
 
 from common import chrome_dependency_fetcher
@@ skipping 17 matching lines @@
 
   RESPONSES = {}
 
   def __init__(self, *_):
     pass
 
   def GetSource(self, path, revision):
     return self.RESPONSES.get(path, {}).get(revision, None)
 
 
+def MockGitilesRepositoryFactory(repo_url):
+  """A factory for creating ``MockGitilesRepository`` objects."""
+  return MockGitilesRepository(repo_url)
+
+
 class ChromiumDEPSTest(testing.AppengineTestCase):
   DEPS_GIT = '.DEPS.git'
   DEPS = 'DEPS'
   deps_downloader = chrome_dependency_fetcher.DEPSDownloader(
-      MockGitilesRepository())
+      MockGitilesRepositoryFactory)
   chrome_dep_fetcher = chrome_dependency_fetcher.ChromeDependencyFetcher(
-      MockGitilesRepository())
+      MockGitilesRepositoryFactory)
 
   def testUseDEPS_GIT(self):
     revision = 'abc'
     expected_content = '.DEPS.git content'
 
     MockGitilesRepository.RESPONSES = {
         self.DEPS_GIT: {
             revision: expected_content
         },
         self.DEPS: {
@@ skipping 67 matching lines @@
                             'https://src.git', 'abc', 'DEPS')
 
   def testDEPSDownloaderForChromeVersion(self):
 
     def _MockGet(*_):
       return 200, base64.b64encode('Dummy DEPS content')
 
     self.mock(http_client_appengine.HttpClientAppengine, '_Get', _MockGet)
 
     deps_downloader = chrome_dependency_fetcher.DEPSDownloader(
-        gitiles_repository.GitilesRepository(
-            http_client=http_client_appengine.HttpClientAppengine()))
+        lambda repo_url: gitiles_repository.GitilesRepository(
+            http_client_appengine.HttpClientAppengine(), repo_url))
     content = deps_downloader.Load(
         'http://chrome-internal', '50.0.1234.0', 'DEPS')
     self.assertEqual(content, 'Dummy DEPS content')
 
     self.assertRaisesRegexp(
         Exception,
         'Failed to pull DEPS file from http://chrome, at revision 50.0.1234.1.',
         self.deps_downloader.Load,
         'http://chrome', '50.0.1234.1', 'DEPS')
 
@@ skipping 143 matching lines @@
             'src/',
             'https://chromium.googlesource.com/chromium/src.git', '4', '5'),
     }
     self.assertEqual(self.chrome_dep_fetcher.GetDependencyRollsDict(
         '4', '5', 'all'), expected_deps_rolls_dict)
 
   def testIsChromeVersion(self):
     self.assertTrue(chrome_dependency_fetcher.IsChromeVersion('50.0.1234.1'))
     self.assertFalse(chrome_dependency_fetcher.IsChromeVersion('a.b.c.e'))
     self.assertFalse(chrome_dependency_fetcher.IsChromeVersion('5.021.2.0.123'))