Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2605933003: Revert "Added isolate + thread high watermark tracking to Observatory" (Closed)

Created:
3 years, 11 months ago by bkonyi
Modified:
3 years, 11 months ago
Reviewers:
siva
CC:
Cutch, reviews_dartlang.org, rmacnak, turnidge, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Added isolate + thread high watermark tracking to Observatory" This reverts commit 0a1a534fd9c67d4b3edc5223569067cb1504f77e. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/e28b3e3c60587acfbe695d25e96dcae4240c5b30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -124 lines) Patch
M runtime/observatory/lib/src/elements/isolate_view.dart View 2 chunks +0 lines, -16 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/isolate.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/thread.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 4 chunks +0 lines, -10 lines 0 comments Download
M runtime/observatory/tests/service/get_zone_memory_info_rpc_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/vm/isolate.h View 3 chunks +1 line, -8 lines 0 comments Download
M runtime/vm/isolate.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M runtime/vm/thread.h View 2 chunks +0 lines, -22 lines 0 comments Download
M runtime/vm/thread.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M runtime/vm/thread_registry.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/thread_registry.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M runtime/vm/thread_test.cc View 2 chunks +3 lines, -14 lines 0 comments Download
M runtime/vm/zone.cc View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
3 years, 11 months ago (2016-12-29 00:48:46 UTC) #2
siva
lgtm
3 years, 11 months ago (2016-12-29 00:49:32 UTC) #3
bkonyi
3 years, 11 months ago (2016-12-29 00:49:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e28b3e3c60587acfbe695d25e96dcae4240c5b30 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698