Add MockInputMethodManager under ui/base/ime/chromeos/

chrome/browser/chromeos/events/event_rewriter_unittest.cc

Index: chrome/browser/chromeos/events/event_rewriter_unittest.cc
diff --git a/chrome/browser/chromeos/events/event_rewriter_unittest.cc b/chrome/browser/chromeos/events/event_rewriter_unittest.cc
index 9364ca475df6f1ff7fefbac544b7447958467934..69439fc934bb9510c612d07ef6f604501e438c6d 100644
--- a/chrome/browser/chromeos/events/event_rewriter_unittest.cc
+++ b/chrome/browser/chromeos/events/event_rewriter_unittest.cc
@@ -16,7 +16,7 @@
 #include "base/macros.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/chromeos/input_method/input_method_configuration.h"
-#include "chrome/browser/chromeos/input_method/mock_input_method_manager.h"
+#include "chrome/browser/chromeos/input_method/mock_input_method_manager_impl.h"
 #include "chrome/browser/chromeos/login/users/fake_chrome_user_manager.h"
 #include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"
 #include "chrome/browser/chromeos/preferences.h"
@@ -127,7 +127,7 @@ class EventRewriterTest : public ash::test::AshTestBase {
 
   void SetUp() override {
     input_method_manager_mock_ =
-        new chromeos::input_method::MockInputMethodManager;
+        new chromeos::input_method::MockInputMethodManagerImpl;
     chromeos::input_method::InitializeForTesting(
         input_method_manager_mock_);  // pass ownership

[sky, 2017/01/03 16:29:46]

Would be nice if this took a unique_ptr so ownership was clear.

[Azure Wei, 2017/01/04 09:13:27]

Do you mean make input_method_manager_mock_ as
std::unique_ptr<MockInputMethodManagerImpl> and pass
input_method_manager_mock_.release() here?
input_method_manager_mock_ is not a real unique_ptr since it will be changed in
TestRewriteCapsLockMod3InUse.

[sky, 2017/01/04 16:35:52]

This is what you have:

chromeos::input_method::InitializeForTesting(
    input_method_manager_mock_);  // pass ownership

You need the comment because it isn't obvious from the code that
InitializeForTesting takes ownership. If InitializeForTesting took a
std::unique_ptr, ownership would be obvious.

I'm not sure what you mean by changing to TestRewriteCapsLockMod3InUse.

 
@@ -154,7 +154,8 @@ class EventRewriterTest : public ash::test::AshTestBase {
 
   chromeos::FakeChromeUserManager* fake_user_manager_;  // Not owned.
   chromeos::ScopedUserManagerEnabler user_manager_enabler_;
-  chromeos::input_method::MockInputMethodManager* input_method_manager_mock_;
+  chromeos::input_method::MockInputMethodManagerImpl*
+      input_method_manager_mock_;
 };
 
 TEST_F(EventRewriterTest, TestRewriteCommandToControl) {