Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1466)

Unified Diff: appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py

Issue 2605803002: [Findit] Refactoring WfTryJobData into BaseTryJobData, WfTryJobData, and FlakeTryJobData (Closed)
Patch Set: Fixing code coverage Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py b/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py
index ed646402fc7dd76c50c75364e5cb548e00df49e8..fd58236693dce511c6749fd672d2e83098f3471d 100644
--- a/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py
+++ b/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py
@@ -6,8 +6,6 @@ import mock
from common.waterfall import buildbucket_client
from common.waterfall import failure_type
-from model.wf_try_job import WfTryJob
-from model.wf_try_job_data import WfTryJobData
from waterfall import schedule_try_job_pipeline
from waterfall.schedule_try_job_pipeline import ScheduleTryJobPipeline
from waterfall.test import wf_testcase
@@ -76,25 +74,3 @@ class ScheduleTryjobPipelineTest(wf_testcase.WaterfallTestCase):
master_name, builder_name, {}, [])
self.assertEqual(build_id, '1')
-
-
- def testCreateTryJobData(self):
- build_id = 1
- master_name = 'm'
- builder_name = 'b'
- build_number = 1
- try_job_type = failure_type.GetDescriptionForFailureType(failure_type.TEST)
-
- ScheduleTryJobPipeline()._CreateTryJobData(
- build_id, master_name, builder_name, build_number, try_job_type,
- False, False)
-
- data = WfTryJobData.Get(build_id)
-
- self.assertIsNotNone(data)
- self.assertEqual(data.master_name, master_name)
- self.assertEqual(data.builder_name, builder_name)
- self.assertEqual(data.build_number, build_number)
- self.assertEqual(data.try_job_type, try_job_type)
- self.assertFalse(data.has_compile_targets)
- self.assertFalse(data.has_heuristic_results)
« no previous file with comments | « appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698