[Findit] Refactoring WfTryJobData into BaseTryJobData, WfTryJobData, and FlakeTryJobData

appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from testing_utils import testing
 
 from common.waterfall import failure_type
 from libs.gitiles.gitiles_repository import GitilesRepository
 from model import analysis_approach_type
 from model import analysis_status
@@ skipping 416 matching lines @@
 
   def testIdentifyCulpritForCompileTryJobNoCulprit(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 1
     try_job_id = '1'
 
     try_job = WfTryJob.Create(master_name, builder_name, build_number)
     try_job.put()
     try_job_data = WfTryJobData.Create(try_job_id)
+    try_job_data.try_job_key = try_job.key
     try_job_data.put()
 
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     culprit = pipeline.run(
         master_name, builder_name, build_number, ['rev1'],
         failure_type.COMPILE, '1', None)
     try_job = WfTryJob.Get(master_name, builder_name, build_number)
@@ skipping 14 matching lines @@
     compile_result = {
         'report': {
             'result': {
                 'rev1': 'passed',
                 'rev2': 'failed'
             },
         },
     }
 
     try_job_data = WfTryJobData.Create(try_job_id)
+    try_job_data.try_job_key = WfTryJob.Create(
+        master_name, builder_name, build_number).key
     try_job_data.put()
 
     try_job = WfTryJob.Create(master_name, builder_name, build_number)
     try_job.status = analysis_status.RUNNING
     try_job.compile_results = [{
         'report': {
             'result': {
                 'rev1': 'passed',
                 'rev2': 'failed'
             },
@@ skipping 62 matching lines @@
         'report': {
             'result': {
                 'rev1': 'passed',
                 'rev2': 'passed'
             }
         },
         'url': 'url',
         'try_job_id': try_job_id,
     }
 
-    WfTryJobData.Create(try_job_id).put()
-    WfTryJob.Create(master_name, builder_name, build_number).put()
+    try_job = WfTryJob.Create(master_name, builder_name, build_number)
+    try_job.put()
+
+    try_job_data = WfTryJobData.Create(try_job_id)
+    try_job_data.try_job_key = try_job.key
+    try_job_data.put()
+
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     culprit = pipeline.run(
         master_name, builder_name, build_number, ['rev1'],
         failure_type.COMPILE, '1', compile_result)
     try_job = WfTryJob.Get(master_name, builder_name, build_number)
 
     self.assertIsNone(culprit)
     self.assertEqual(analysis_status.COMPLETED, try_job.status)
 
     try_job_data = WfTryJobData.Get(try_job_id)
     self.assertIsNone(try_job_data.culprits)
 
     self.assertIsNone(analysis.result_status)
     self.assertIsNone(analysis.suspected_cls)
 
   def testIdentifyCulpritForTestTryJobNoTryJobResultNoHeuristicResult(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 1
     try_job_id = '1'
 
-    WfTryJobData.Create(try_job_id).put()
     try_job = WfTryJob.Create(master_name, builder_name, build_number)
     try_job.status = analysis_status.RUNNING
     try_job.put()
+
+    try_job_data = WfTryJobData.Create(try_job_id)
+    try_job_data.try_job_key = try_job.key
+    try_job_data.put()
+
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     culprit = pipeline.run(
         master_name, builder_name, build_number, ['rev1', 'rev2'],
         failure_type.TEST, '1', None)
 
     self.assertIsNone(culprit)
 
     try_job_data = WfTryJobData.Get(try_job_id)
     self.assertIsNone(try_job_data.culprits)
     self.assertIsNone(analysis.result_status)
     self.assertIsNone(analysis.suspected_cls)
 
   def testIdentifyCulpritForTestTryJobNoTryJobResultWithHeuristicResult(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 1
     try_job_id = '1'
 
     suspected_cl = {
         'revision': 'rev1',
         'commit_position': 1,
         'url': 'url_1',
         'repo_name': 'chromium'
     }
 
-    WfTryJobData.Create(try_job_id).put()
     try_job = WfTryJob.Create(master_name, builder_name, build_number)
     try_job.status = analysis_status.RUNNING
     try_job.put()
 
+    try_job_data = WfTryJobData.Create(try_job_id)
+    try_job_data.try_job_key = try_job.key
+    try_job_data.put()
+
     # Heuristic analysis already provided some results.
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.result_status = result_status.FOUND_UNTRIAGED
     analysis.suspected_cls = [suspected_cl]
     analysis.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     culprit = pipeline.run(
         master_name, builder_name, build_number, ['rev1', 'rev2'],
         failure_type.TEST, '1', None)
@@ skipping 22 matching lines @@
                         'valid': True,
                         'failures': ['a_test1']
                     }
                 }
             }
         },
         'url': 'url',
         'try_job_id': try_job_id
     }
 
-    WfTryJobData.Create(try_job_id).put()
     try_job = WfTryJob.Create(master_name, builder_name, build_number)
     try_job.status = analysis_status.RUNNING
     try_job.put()
+    
+    try_job_data = WfTryJobData.Create(try_job_id)
+    try_job_data.try_job_key = try_job.key
+    try_job_data.put()
+
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     culprit = pipeline.run(
         master_name, builder_name, build_number, [], failure_type.TEST, '1',
         test_result)
 
     self.assertIsNone(culprit)
 
@@ skipping 18 matching lines @@
                         'valid': True,
                         'failures': ['a_test1']
                     }
                 }
             }
         },
         'url': 'url',
         'try_job_id': try_job_id
     }
 
-    WfTryJobData.Create(try_job_id).put()
     try_job = WfTryJob.Create(master_name, builder_name, build_number)
     try_job.status = analysis_status.RUNNING
     try_job.put()
+
+    try_job_data = WfTryJobData.Create(try_job_id)
+    try_job_data.try_job_key = try_job.key
+    try_job_data.put()
+
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     culprit = pipeline.run(
         master_name, builder_name, build_number, ['rev3'], failure_type.TEST,
         '1', test_result)
 
     expected_suspected_cl = {
         'revision': 'rev3',
@@ skipping 62 matching lines @@
                         'status': 'passed',
                         'valid': True
                     }
                 }
             }
         },
         'url': 'url',
         'try_job_id': try_job_id
     }
 
-    WfTryJobData.Create(try_job_id).put()
     try_job = WfTryJob.Create(master_name, builder_name, build_number)
     try_job.status = analysis_status.RUNNING
     try_job.test_results = [test_result]
     try_job.put()
+
+    try_job_data = WfTryJobData.Create(try_job_id)
+    try_job_data.try_job_key = try_job.key
+    try_job_data.put()
+
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     culprit = pipeline.run(
         master_name, builder_name, build_number, ['rev1', 'rev2'],
         failure_type.TEST, '1', test_result)
 
     a_test1_suspected_cl = {
         'revision': 'rev1',
@@ skipping 139 matching lines @@
     suspected_cl.put()
 
     compile_result = {
         'report': {
             'result': {
                 revision: 'failed',
             },
         },
     }
 
-    try_job_data = WfTryJobData.Create(try_job_id)
-    try_job_data.put()
-
     try_job = WfTryJob.Create(master_name, builder_name, build_number)
     try_job.status = analysis_status.RUNNING
     try_job.compile_results = [{
         'report': {
             'result': {
                 revision: 'failed',
             },
         },
         'try_job_id': try_job_id,
     }]
+    try_job.put()
 
-    try_job.put()
+    try_job_data = WfTryJobData.Create(try_job_id)
+    try_job_data.try_job_key = try_job.key
+    try_job_data.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     pipeline.run(master_name, builder_name, build_number, [revision],
                  failure_type.COMPILE, '1', compile_result)
 
     self.assertEqual(analysis.result_status,
                      result_status.FOUND_UNTRIAGED)
     self.assertEqual(analysis.suspected_cls, [heuristic_suspected_cl])
     self.assertEqual(version, analysis.version)  # No update to analysis.
 
@@ skipping 196 matching lines @@
 
     identify_try_job_culprit_pipeline._NotifyCulprits(
         master_name, builder_name, build_number, None,
         heuristic_cls, compile_suspected_cl)
     self.assertEqual(1, len(instances))
     self.assertTrue(instances[0].started)
 
   def testGetTestFailureCausedByCLResultNone(self):
     self.assertIsNone(
         identify_try_job_culprit_pipeline._GetTestFailureCausedByCL(None))