[Findit] Refactoring WfTryJobData into BaseTryJobData, WfTryJobData, and FlakeTryJobData

appengine/findit/handlers/test/try_job_dashboard_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import datetime
-from datetime import timedelta
 import json
 
 import webapp2
 
 from handlers import try_job_dashboard
+from model.wf_try_job import WfTryJob
 from model.wf_try_job_data import WfTryJobData
 
 from testing_utils import testing
 
 
 class TryJobDashboardTest(testing.AppengineTestCase):
   app_module = webapp2.WSGIApplication([
       ('/try-job-dashboard', try_job_dashboard.TryJobDashboard),
   ], debug=True)
 
@@ skipping 48 matching lines @@
     self.assertEqual(
         try_job_dashboard._PrepareBuildbucketResponseForDisplay(
             buildbucket_response),
         {
             'blabla': 'blabla',
             'has_json': properties
         })
 
   def testGet(self):
     try_job_in_progress = WfTryJobData.Create(1)
-    try_job_in_progress.master_name = 'm'
-    try_job_in_progress.builder_name = 'b'
-    try_job_in_progress.build_number = 1
+    try_job_in_progress.try_job_key = WfTryJob.Create('m', 'b', 1).key
     try_job_in_progress.try_job_type = 'compile'
     try_job_in_progress.start_time = datetime(2016, 5, 4, 0, 0, 1)
     try_job_in_progress.request_time = datetime(2016, 5, 4, 0, 0, 0)
     try_job_in_progress.try_job_url = 'url1'
     try_job_in_progress.last_buildbucket_response = {'status': 'STARTED'}
     try_job_in_progress.put()
 
     try_job_with_error = WfTryJobData.Create(2)
-    try_job_with_error.master_name = 'm'
-    try_job_with_error.builder_name = 'b'
-    try_job_with_error.build_number = 2
+    try_job_with_error.try_job_key = WfTryJob.Create('m', 'b', 2).key
     try_job_with_error.try_job_type = 'compile'
     try_job_with_error.start_time = datetime(2016, 5, 4, 0, 0, 1)
     try_job_with_error.request_time = datetime(2016, 5, 4, 0, 0, 0)
     try_job_with_error.end_time = datetime(2016, 5, 4, 0, 0, 2)
     try_job_with_error.try_job_url = 'url2'
     try_job_with_error.error = {
         'message': 'some error',
         'reason': 'some reason'
     }
     try_job_with_error.last_buildbucket_response = {
         'failure_reason': 'INFRA_FAILURE'
     }
     try_job_with_error.put()
 
     try_job_completed = WfTryJobData.Create(3)
-    try_job_completed.master_name = 'm'
-    try_job_completed.builder_name = 'b'
-    try_job_completed.build_number = 3
+    try_job_completed.try_job_key = WfTryJob.Create('m', 'b', 3).key
     try_job_completed.try_job_type = 'compile'
     try_job_completed.start_time = datetime(2016, 5, 4, 0, 0, 1)
     try_job_completed.request_time = datetime(2016, 5, 4, 0, 0, 0)
     try_job_completed.end_time = datetime(2016, 5, 4, 0, 0, 2)
     try_job_completed.try_job_url = 'url3'
     try_job_completed.culprits = {
         'compile': {
             '12345': 'failed'
         }
     }
@@ skipping 46 matching lines @@
     self.assertEqual(response.status_int, 200)
     self.validateTryJobDisplayData(
         [expected_try_job_in_progress_display_data],
         try_jobs_in_progress)
     self.validateTryJobDisplayData(
         [expected_try_job_with_error_display_data],
         try_jobs_with_error)
     self.validateTryJobDisplayData(
         [expected_try_job_completed_display_data],
         successfully_completed_try_jobs)