Fix Aura can't provide accurate cursor hotspot info.

ui/base/cursor/cursors_aura.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/cursor/cursors_aura.h"
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "third_party/skia/include/core/SkBitmap.h"
@@ skipping 157 matching lines @@
                  int id,
                  float scale_factor,
                  int* resource_id,
                  gfx::Point* point) {
   bool resource_2x_available =
       ResourceBundle::GetSharedInstance().GetMaxScaleFactor() ==
       SCALE_FACTOR_200P;
   for (size_t i = 0; i < table_length; ++i) {
     if (table[i].id == id) {
       *resource_id = table[i].resource_id;
-      *point = scale_factor == 1.0f || !resource_2x_available ?
-               gfx::Point(table[i].hot_1x.x, table[i].hot_1x.y) :
-               gfx::Point(table[i].hot_2x.x, table[i].hot_2x.y);
+      *point = scale_factor != 2.0f || !resource_2x_available
+                   ? gfx::Point(table[i].hot_1x.x, table[i].hot_1x.y)
+                   : gfx::Point(table[i].hot_2x.x, table[i].hot_2x.y);

[sadrul, 2017/01/03 17:18:09]

Why change this?

[braveyao, 2017/01/03 17:30:51]

To make the 1x as the default, which I suppose could cover the most
cases(especially for the scale factor missing). This may not be needed after
this fix. But still good to have.  WDYT?

[sadrul, 2017/01/04 16:16:24]

I think we prefer the 2x versions for other image resources when scale factor !=
1, at least on ChromeOS (and > 1.25 on windows, looks like) [*]. Is there a
reason for cursors to be different?

*:
https://cs.chromium.org/chromium/src/ui/base/resource/resource_bundle.cc?sq=p...

[braveyao, 2017/01/04 17:37:36]

Done.

       return true;
     }
   }
 
   return false;
 }
 
 }  // namespace
 
 bool GetCursorDataFor(CursorSetType cursor_set_id,
@@ skipping 41 matching lines @@
 bool GetCursorBitmap(const Cursor& cursor,
                      SkBitmap* bitmap,
                      gfx::Point* point) {
   DCHECK(bitmap && point);
 #if defined(OS_WIN)
   Cursor cursor_copy = cursor;
   ui::CursorLoaderWin cursor_loader;
   cursor_loader.SetPlatformCursor(&cursor_copy);
   const std::unique_ptr<SkBitmap> cursor_bitmap(
       IconUtil::CreateSkBitmapFromHICON(cursor_copy.platform()));
+  *point = IconUtil::GetHotSpotFromHICON(cursor_copy.platform());
 #else
   int resource_id;
   if (!GetCursorDataFor(ui::CURSOR_SET_NORMAL,
                         cursor.native_type(),
                         cursor.device_scale_factor(),
                         &resource_id,
                         point)) {
     return false;
   }
 
   const SkBitmap* cursor_bitmap = ResourceBundle::GetSharedInstance().
       GetImageSkiaNamed(resource_id)->bitmap();
 #endif
   if (!cursor_bitmap)
     return false;
   *bitmap = *cursor_bitmap;
   return true;
 }
 
 }  // namespace ui