third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js - Issue 2605693003: DevTools: introduce object previews experiment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

Issue 2605693003: DevTools: introduce object previews experiment (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

index 4de10f215617fb049192057d8ada2c1aa07f603b..d7892a77dad313f3dcf38f1aedb1914993e00ed1 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

@@ -684,7 +684,8 @@ SDK.DebuggerModel = class extends SDK.SDKModel {

* @return {!Promise<?SDK.DebuggerModel.FunctionDetails>}

functionDetailsPromise(remoteObject) {

- return remoteObject.getAllPropertiesPromise(/* accessorPropertiesOnly */ false).then(buildDetails.bind(this));

+ return remoteObject.getAllPropertiesPromise(false /* accessorPropertiesOnly */, false /* generatePreview */)

+ .then(buildDetails.bind(this));

/**

* @param {!{properties: ?Array.<!SDK.RemoteObjectProperty>, internalProperties: ?Array.<!SDK.RemoteObjectProperty>}} response