Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1608)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js

Issue 2605693003: DevTools: introduce object previews experiment (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js b/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js
index b9aad4f0374aa194fbc76020491617051507f0b3..379e79ab536d2980612a945984ac5b8760f45bf0 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js
@@ -104,7 +104,9 @@ Components.JavaScriptAutocomplete.completionsForExpression = function(expression
return Promise.resolve(/** @type {?SDK.RemoteObject} */ (null));
if (object.type !== 'object' || object.subtype !== 'proxy')
return Promise.resolve(/** @type {?SDK.RemoteObject} */ (object));
- return object.getOwnPropertiesPromise().then(extractTargetFromProperties).then(extractTarget);
+ return object.getOwnPropertiesPromise(false /* generatePreview */)
+ .then(extractTargetFromProperties)
+ .then(extractTarget);
}
/**
@@ -206,7 +208,9 @@ Components.JavaScriptAutocomplete.completionsForExpression = function(expression
for (var i = 0; i < scopeChain.length; ++i) {
var scope = scopeChain[i];
var object = scope.object();
- object.getAllProperties(false, propertiesCollected.bind(null, scope.typeName()));
+ object.getAllProperties(
+ false /* accessorPropertiesOnly */, false /* generatePreview */,
+ propertiesCollected.bind(null, scope.typeName()));
}
}

Powered by Google App Engine
This is Rietveld 408576698