DevTools: introduce object previews experiment

third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 61 matching lines @@
       return 0;
     // Array lengths in V8-generated descriptions switched from square brackets to parentheses.
     // Both formats are checked in case the front end is dealing with an old version of V8.
     var matches = object.description.match(/\[([0-9]+)\]/) || object.description.match(/\(([0-9]+)\)/);
     if (!matches)
       return 0;
     return parseInt(matches[1], 10);
   }
 
   /**
+   * @param {!Protocol.Runtime.ObjectPreview} preview
+   * @return {number}
+   */
+  static numEntries(preview) {

[dgozman, 2017/01/10 22:26:10]

setOrMapEntriesCount

[luoe, 2017/01/13 01:11:45]

mapOrSetEntriesCount

+    if (preview.subtype !== 'map' && preview.subtype !== 'set')
+      return 0;
+    var matches = preview.description.match(/\(([0-9]+)\)/);
+    if (!matches)
+      return 0;
+    return parseInt(matches[1], 10);
+  }
+
+  /**
    * @param {!Protocol.Runtime.RemoteObject|!SDK.RemoteObject|number|string|boolean|undefined|null} object
    * @return {!Protocol.Runtime.CallArgument}
    */
   static toCallArgument(object) {
     var type = typeof object;
     if (type === 'undefined')
       return {};
     if (type === 'number') {
       var description = String(object);
       if (object === 0 && 1 / object < 0)
@@ skipping 398 matching lines @@
    */
   get preview() {
     return this._preview;
   }
 
   /**
    * @override
    * @param {function(?Array.<!SDK.RemoteObjectProperty>, ?Array.<!SDK.RemoteObjectProperty>)} callback
    */
   getOwnProperties(callback) {
-    this.doGetProperties(true, false, false, callback);
+    if (Runtime.experiments.isEnabled('objectPreviews'))

[dgozman, 2017/01/10 22:26:10]

Instead of checking experiment here, we should pass generatePreview flag from
the caller.

[luoe, 2017/01/13 01:11:45]

Moved to a few callers in ObjectPropertiesSection.js

+      this.doGetProperties(true, false, true, callback);
+    else
+      this.doGetProperties(true, false, false, callback);
   }
 
   /**
    * @override
    * @param {boolean} accessorPropertiesOnly
    * @param {function(?Array.<!SDK.RemoteObjectProperty>, ?Array.<!SDK.RemoteObjectProperty>)} callback
    */
   getAllProperties(accessorPropertiesOnly, callback) {
-    this.doGetProperties(false, accessorPropertiesOnly, false, callback);
+    if (Runtime.experiments.isEnabled('objectPreviews'))

[dgozman, 2017/01/10 22:26:10]

ditto

[luoe, 2017/01/13 01:11:46]

Done.

+      this.doGetProperties(false, accessorPropertiesOnly, true, callback);
+    else
+      this.doGetProperties(false, accessorPropertiesOnly, false, callback);
   }
 
   /**
    * @override
    * @return {!Promise<?Array<!SDK.EventListener>>}
    */
   eventListeners() {
     return new Promise(eventListeners.bind(this));
     /**
      * @param {function(?)} fulfill
@@ skipping 896 matching lines @@
     }
   }
 
   /**
    * @return {!SDK.RemoteObject}
    */
   object() {
     return this._object;
   }
 };