Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

Issue 2605693003: DevTools: introduce object previews experiment (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) IBM Corp. 2009 All rights reserved. 2 * Copyright (C) IBM Corp. 2009 All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 deleteButton.addEventListener('click', this._deleteWatchExpression.bind(this ), false); 328 deleteButton.addEventListener('click', this._deleteWatchExpression.bind(this ), false);
329 329
330 var titleElement = headerElement.createChild('div', 'watch-expression-title' ); 330 var titleElement = headerElement.createChild('div', 'watch-expression-title' );
331 this._nameElement = Components.ObjectPropertiesSection.createNameElement(thi s._expression); 331 this._nameElement = Components.ObjectPropertiesSection.createNameElement(thi s._expression);
332 if (!!exceptionDetails || !result) { 332 if (!!exceptionDetails || !result) {
333 this._valueElement = createElementWithClass('span', 'watch-expression-erro r value'); 333 this._valueElement = createElementWithClass('span', 'watch-expression-erro r value');
334 titleElement.classList.add('dimmed'); 334 titleElement.classList.add('dimmed');
335 this._valueElement.textContent = Common.UIString('<not available>'); 335 this._valueElement.textContent = Common.UIString('<not available>');
336 } else { 336 } else {
337 this._valueElement = Components.ObjectPropertiesSection.createValueElement WithCustomSupport( 337 this._valueElement = Components.ObjectPropertiesSection.createValueElement WithCustomSupport(
338 result, !!exceptionDetails, titleElement, this._linkifier); 338 result, !!exceptionDetails, false /* showPreview */, titleElement, thi s._linkifier);
339 } 339 }
340 var separatorElement = createElementWithClass('span', 'watch-expressions-sep arator'); 340 var separatorElement = createElementWithClass('span', 'watch-expressions-sep arator');
341 separatorElement.textContent = ': '; 341 separatorElement.textContent = ': ';
342 titleElement.appendChildren(this._nameElement, separatorElement, this._value Element); 342 titleElement.appendChildren(this._nameElement, separatorElement, this._value Element);
343 343
344 this._element.removeChildren(); 344 this._element.removeChildren();
345 this._objectPropertiesSection = null; 345 this._objectPropertiesSection = null;
346 if (!exceptionDetails && result && result.hasChildren && !result.customPrevi ew()) { 346 if (!exceptionDetails && result && result.hasChildren && !result.customPrevi ew()) {
347 headerElement.classList.add('watch-expression-object-header'); 347 headerElement.classList.add('watch-expression-object-header');
348 this._objectPropertiesSection = new Components.ObjectPropertiesSection(res ult, headerElement, this._linkifier); 348 this._objectPropertiesSection = new Components.ObjectPropertiesSection(res ult, headerElement, this._linkifier);
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 InspectorFrontendHost.copyText(this._valueElement.textContent); 417 InspectorFrontendHost.copyText(this._valueElement.textContent);
418 } 418 }
419 }; 419 };
420 420
421 Sources.WatchExpression._watchObjectGroupId = 'watch-group'; 421 Sources.WatchExpression._watchObjectGroupId = 'watch-group';
422 422
423 /** @enum {symbol} */ 423 /** @enum {symbol} */
424 Sources.WatchExpression.Events = { 424 Sources.WatchExpression.Events = {
425 ExpressionUpdated: Symbol('ExpressionUpdated') 425 ExpressionUpdated: Symbol('ExpressionUpdated')
426 }; 426 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698