DevTools: introduce object previews experiment

third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 61 matching lines @@
       return 0;
     // Array lengths in V8-generated descriptions switched from square brackets to parentheses.
     // Both formats are checked in case the front end is dealing with an old version of V8.
     var matches = object.description.match(/\[([0-9]+)\]/) || object.description.match(/\(([0-9]+)\)/);
     if (!matches)
       return 0;
     return parseInt(matches[1], 10);
   }
 
   /**
+   * @param {!Protocol.Runtime.ObjectPreview} preview
+   * @return {number}
+   */
+  static mapOrSetEntriesCount(preview) {
+    if (preview.subtype !== 'map' && preview.subtype !== 'set')
+      return 0;
+    var matches = preview.description.match(/\(([0-9]+)\)/);
+    if (!matches)
+      return 0;
+    return parseInt(matches[1], 10);
+  }
+
+  /**
    * @param {!Protocol.Runtime.RemoteObject|!SDK.RemoteObject|number|string|boolean|undefined|null} object
    * @return {!Protocol.Runtime.CallArgument}
    */
   static toCallArgument(object) {
     var type = typeof object;
     if (type === 'undefined')
       return {};
     if (type === 'number') {
       var description = String(object);
       if (object === 0 && 1 / object < 0)
@@ skipping 20 matching lines @@
     if (typeof object.objectId !== 'undefined')
       return {objectId: object.objectId};
     if (typeof object._objectId !== 'undefined')
       return {objectId: object._objectId};
 
     return {value: object.value};
   }
 
   /**
    * @param {!SDK.RemoteObject} object
+   * @param {boolean} generatePreview
    * @param {function(?Array.<!SDK.RemoteObjectProperty>, ?Array.<!SDK.RemoteObjectProperty>)} callback
    */
-  static loadFromObjectPerProto(object, callback) {
+  static loadFromObjectPerProto(object, generatePreview, callback) {
     // Combines 2 asynch calls. Doesn't rely on call-back orders (some calls may be loop-back).
     var savedOwnProperties;
     var savedAccessorProperties;
     var savedInternalProperties;
     var resultCounter = 2;
 
     function processCallback() {
       if (--resultCounter)
         return;
       if (savedOwnProperties && savedAccessorProperties) {
@@ skipping 35 matching lines @@
     /**
      * @param {?Array.<!SDK.RemoteObjectProperty>} properties
      * @param {?Array.<!SDK.RemoteObjectProperty>} internalProperties
      */
     function ownPropertiesCallback(properties, internalProperties) {
       savedOwnProperties = properties;
       savedInternalProperties = internalProperties;
       processCallback();
     }
 
-    object.getAllProperties(true, allAccessorPropertiesCallback);
-    object.getOwnProperties(ownPropertiesCallback);
+    object.getAllProperties(true, generatePreview, allAccessorPropertiesCallback);
+    object.getOwnProperties(generatePreview, ownPropertiesCallback);
   }
 
   /**
    * @return {?Protocol.Runtime.CustomPreview}
    */
   customPreview() {
     return null;
   }
 
   /** @return {string} */
@@ skipping 17 matching lines @@
   }
 
   /**
    * @return {number}
    */
   arrayLength() {
     throw 'Not implemented';
   }
 
   /**
+   * @param {boolean} generatePreview
    * @param {function(?Array.<!SDK.RemoteObjectProperty>, ?Array.<!SDK.RemoteObjectProperty>)} callback
    */
-  getOwnProperties(callback) {
+  getOwnProperties(generatePreview, callback) {
     throw 'Not implemented';
   }
 
   /**
+   * @param {boolean=} generatePreview

[dgozman, 2017/01/13 02:55:42]

Don't make it optional.

[luoe, 2017/01/13 23:20:13]

Done.

    * @return {!Promise<!{properties: ?Array.<!SDK.RemoteObjectProperty>, internalProperties: ?Array.<!SDK.RemoteObjectProperty>}>}
    */
-  getOwnPropertiesPromise() {
+  getOwnPropertiesPromise(generatePreview) {
     return new Promise(promiseConstructor.bind(this));
 
     /**
      * @param {function(!{properties: ?Array.<!SDK.RemoteObjectProperty>, internalProperties: ?Array.<!SDK.RemoteObjectProperty>})} success
      * @this {SDK.RemoteObject}
      */
     function promiseConstructor(success) {
-      this.getOwnProperties(getOwnPropertiesCallback.bind(null, success));
+      this.getOwnProperties(!!generatePreview, getOwnPropertiesCallback.bind(null, success));
     }
 
     /**
      * @param {function(!{properties: ?Array.<!SDK.RemoteObjectProperty>, internalProperties: ?Array.<!SDK.RemoteObjectProperty>})} callback
      * @param {?Array.<!SDK.RemoteObjectProperty>} properties
      * @param {?Array.<!SDK.RemoteObjectProperty>} internalProperties
      */
     function getOwnPropertiesCallback(callback, properties, internalProperties) {
       callback({properties: properties, internalProperties: internalProperties});
     }
   }
 
   /**
    * @param {boolean} accessorPropertiesOnly
+   * @param {boolean} generatePreview
    * @param {function(?Array<!SDK.RemoteObjectProperty>, ?Array<!SDK.RemoteObjectProperty>)} callback
    */
-  getAllProperties(accessorPropertiesOnly, callback) {
+  getAllProperties(accessorPropertiesOnly, generatePreview, callback) {
     throw 'Not implemented';
   }
 
   /**
    * @param {boolean} accessorPropertiesOnly
+   * @param {boolean} generatePreview
    * @return {!Promise<!{properties: ?Array<!SDK.RemoteObjectProperty>, internalProperties: ?Array<!SDK.RemoteObjectProperty>}>}
    */
-  getAllPropertiesPromise(accessorPropertiesOnly) {
+  getAllPropertiesPromise(accessorPropertiesOnly, generatePreview) {
     return new Promise(promiseConstructor.bind(this));
 
     /**
      * @param {function(!{properties: ?Array<!SDK.RemoteObjectProperty>, internalProperties: ?Array.<!SDK.RemoteObjectProperty>})} success
      * @this {SDK.RemoteObject}
      */
     function promiseConstructor(success) {
-      this.getAllProperties(accessorPropertiesOnly, getAllPropertiesCallback.bind(null, success));
+      this.getAllProperties(accessorPropertiesOnly, generatePreview, getAllPropertiesCallback.bind(null, success));
     }
 
     /**
      * @param {function(!{properties: ?Array<!SDK.RemoteObjectProperty>, internalProperties: ?Array<!SDK.RemoteObjectProperty>})} callback
      * @param {?Array<!SDK.RemoteObjectProperty>} properties
      * @param {?Array<!SDK.RemoteObjectProperty>} internalProperties
      */
     function getAllPropertiesCallback(callback, properties, internalProperties) {
       callback({properties: properties, internalProperties: internalProperties});
     }
@@ skipping 207 matching lines @@
 
   /**
    * @return {!Protocol.Runtime.ObjectPreview|undefined}
    */
   get preview() {
     return this._preview;
   }
 
   /**
    * @override
+   * @param {boolean} generatePreview
    * @param {function(?Array.<!SDK.RemoteObjectProperty>, ?Array.<!SDK.RemoteObjectProperty>)} callback
    */
-  getOwnProperties(callback) {
-    this.doGetProperties(true, false, false, callback);
+  getOwnProperties(generatePreview, callback) {
+    this.doGetProperties(true, false, generatePreview, callback);
   }
 
   /**
    * @override
    * @param {boolean} accessorPropertiesOnly
+   * @param {boolean} generatePreview
    * @param {function(?Array.<!SDK.RemoteObjectProperty>, ?Array.<!SDK.RemoteObjectProperty>)} callback
    */
-  getAllProperties(accessorPropertiesOnly, callback) {
-    this.doGetProperties(false, accessorPropertiesOnly, false, callback);
+  getAllProperties(accessorPropertiesOnly, generatePreview, callback) {
+    this.doGetProperties(false, accessorPropertiesOnly, generatePreview, callback);
   }
 
   /**
    * @override
    * @return {!Promise<?Array<!SDK.EventListener>>}
    */
   eventListeners() {
     return new Promise(eventListeners.bind(this));
     /**
      * @param {function(?)} fulfill
@@ skipping 598 matching lines @@
    * @return {boolean}
    */
   get hasChildren() {
     if ((typeof this._value !== 'object') || (this._value === null))
       return false;
     return !!Object.keys(/** @type {!Object} */ (this._value)).length;
   }
 
   /**
    * @override
+   * @param {boolean} generatePreview
    * @param {function(?Array.<!SDK.RemoteObjectProperty>, ?Array.<!SDK.RemoteObjectProperty>)} callback
    */
-  getOwnProperties(callback) {
+  getOwnProperties(generatePreview, callback) {
     callback(this._children(), null);
   }
 
   /**
    * @override
    * @param {boolean} accessorPropertiesOnly
+   * @param {boolean} generatePreview
    * @param {function(?Array.<!SDK.RemoteObjectProperty>, ?Array.<!SDK.RemoteObjectProperty>)} callback
    */
-  getAllProperties(accessorPropertiesOnly, callback) {
+  getAllProperties(accessorPropertiesOnly, generatePreview, callback) {
     if (accessorPropertiesOnly)
       callback([], null);
     else
       callback(this._children(), null);
   }
 
   /**
    * @return {!Array.<!SDK.RemoteObjectProperty>}
    */
   _children() {
@@ skipping 266 matching lines @@
     }
   }
 
   /**
    * @return {!SDK.RemoteObject}
    */
   object() {
     return this._object;
   }
 };