Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

Issue 2605693003: DevTools: introduce object previews experiment (Closed)
Patch Set: fix rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 666 matching lines...) Expand 10 before | Expand all | Expand 10 after
677 677
678 this.selectedCallFrame().evaluate( 678 this.selectedCallFrame().evaluate(
679 code, objectGroup, includeCommandLineAPI, silent, returnByValue, generat ePreview, didEvaluate.bind(this)); 679 code, objectGroup, includeCommandLineAPI, silent, returnByValue, generat ePreview, didEvaluate.bind(this));
680 } 680 }
681 681
682 /** 682 /**
683 * @param {!SDK.RemoteObject} remoteObject 683 * @param {!SDK.RemoteObject} remoteObject
684 * @return {!Promise<?SDK.DebuggerModel.FunctionDetails>} 684 * @return {!Promise<?SDK.DebuggerModel.FunctionDetails>}
685 */ 685 */
686 functionDetailsPromise(remoteObject) { 686 functionDetailsPromise(remoteObject) {
687 return remoteObject.getAllPropertiesPromise(/* accessorPropertiesOnly */ fal se).then(buildDetails.bind(this)); 687 return remoteObject.getAllPropertiesPromise(false, false).then(buildDetails. bind(this));
dgozman 2017/01/13 02:55:41 Please restore the comment (and add a new one).
luoe 2017/01/13 23:20:12 Done.
688 688
689 /** 689 /**
690 * @param {!{properties: ?Array.<!SDK.RemoteObjectProperty>, internalPropert ies: ?Array.<!SDK.RemoteObjectProperty>}} response 690 * @param {!{properties: ?Array.<!SDK.RemoteObjectProperty>, internalPropert ies: ?Array.<!SDK.RemoteObjectProperty>}} response
691 * @return {?SDK.DebuggerModel.FunctionDetails} 691 * @return {?SDK.DebuggerModel.FunctionDetails}
692 * @this {!SDK.DebuggerModel} 692 * @this {!SDK.DebuggerModel}
693 */ 693 */
694 function buildDetails(response) { 694 function buildDetails(response) {
695 if (!response) 695 if (!response)
696 return null; 696 return null;
697 var location = null; 697 var location = null;
(...skipping 657 matching lines...) Expand 10 before | Expand all | Expand 10 after
1355 stack.callFrames.shift(); 1355 stack.callFrames.shift();
1356 if (previous && !stack.callFrames.length) 1356 if (previous && !stack.callFrames.length)
1357 previous.parent = stack.parent; 1357 previous.parent = stack.parent;
1358 else 1358 else
1359 previous = stack; 1359 previous = stack;
1360 stack = stack.parent; 1360 stack = stack.parent;
1361 } 1361 }
1362 return asyncStackTrace; 1362 return asyncStackTrace;
1363 } 1363 }
1364 }; 1364 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698