Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2605653002: Subzero: Fix build problem against LLVM trunk. (Closed)

Created:
3 years, 11 months ago by Jim Stichnoth
Modified:
3 years, 11 months ago
Reviewers:
Eric Holk, Karl, John
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix build problem against LLVM trunk. LLVM commit 4ac35e82723d4bdbc094f73b2d33aaaa86a00d6a removed some code that Subzero still needs, specifically StreamingMemoryObject and its parents. Deal with this by adding those files back to the Subzero repo. This allows Subzero to build through LLVM c75e3c2fd2bb9ca010f4e1c32acbd142adc32c7f. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=d722ff2022b623710d9f89f090f162d7f5d521f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+431 lines, -0 lines) Patch
A pnacl-llvm/DataStream.cpp View 1 chunk +86 lines, -0 lines 0 comments Download
A pnacl-llvm/MemoryObject.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
A pnacl-llvm/StreamingMemoryObject.cpp View 1 chunk +138 lines, -0 lines 0 comments Download
A pnacl-llvm/include/llvm/Support/DataStream.h View 1 chunk +38 lines, -0 lines 0 comments Download
A pnacl-llvm/include/llvm/Support/MemoryObject.h View 1 chunk +68 lines, -0 lines 0 comments Download
A pnacl-llvm/include/llvm/Support/StreamingMemoryObject.h View 1 chunk +87 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
3 years, 11 months ago (2016-12-26 19:55:54 UTC) #3
Karl
LGTM. I had seen the change go by (in fact I was contacted about it). ...
3 years, 11 months ago (2016-12-26 20:15:04 UTC) #4
Jim Stichnoth
3 years, 11 months ago (2016-12-27 04:10:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d722ff2022b623710d9f89f090f162d7f5d521f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698