Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.h

Issue 2605553002: Add EffectiveConnectionType enum to the system profile proto (Closed)
Patch Set: Add tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_metrics_service_client.h
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.h b/chrome/browser/metrics/chrome_metrics_service_client.h
index 16f59c6e688d2d37b94733f85998a1af9377f82f..10b6dca0ecb578efa3a98bbd65be4088195cd406 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.h
+++ b/chrome/browser/metrics/chrome_metrics_service_client.h
@@ -40,9 +40,14 @@ namespace metrics {
class DriveMetricsProvider;
class MetricsService;
class MetricsStateManager;
+class NetworkMetricsProvider;
class ProfilerMetricsProvider;
} // namespace metrics
+namespace net {
+class NetworkQualityEstimator;
+} // namespace net
+
// ChromeMetricsServiceClient provides an implementation of MetricsServiceClient
// that depends on chrome/.
class ChromeMetricsServiceClient
@@ -136,6 +141,10 @@ class ChromeMetricsServiceClient
// Called when a URL is opened from the Omnibox.
void OnURLOpenedFromOmnibox(OmniboxLog* log);
+ // Provides the network quality estimator to |network_metrics_provider|.
+ void ProvideNetworkQualityEstimator(
+ net::NetworkQualityEstimator* network_quality_estimator) const;
+
#if defined(OS_WIN)
// Counts (and removes) the browser crash dump attempt signals left behind by
// any previous browser processes which generated a crash dump.
@@ -219,6 +228,10 @@ class ChromeMetricsServiceClient
// Profiler data is uploaded at most once per session.
bool has_uploaded_profiler_data_;
+ // The NetworkMetricsProvider instance that was registered with
+ // MetricsService. Has the same lifetime as |metrics_service_|.
+ metrics::NetworkMetricsProvider* network_metrics_provider_;
+
base::WeakPtrFactory<ChromeMetricsServiceClient> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(ChromeMetricsServiceClient);

Powered by Google App Engine
This is Rietveld 408576698