Add EffectiveConnectionType enum to the system profile proto

chromecast/browser/metrics/cast_metrics_service_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/metrics/cast_metrics_service_client.h"
 
 #include "base/command_line.h"
 #include "base/guid.h"
 #include "base/i18n/rtl.h"
 #include "base/logging.h"
@@ skipping 340 matching lines @@
             new ::metrics::GPUMetricsProvider));
 
     // TODO(gfhuang): Does ChromeCast actually need metrics about screen info?
     // crbug.com/541577
     metrics_service_->RegisterMetricsProvider(
         std::unique_ptr<::metrics::MetricsProvider>(
             new ::metrics::ScreenInfoMetricsProvider));
   }
   metrics_service_->RegisterMetricsProvider(
       std::unique_ptr<::metrics::MetricsProvider>(
-          new ::metrics::NetworkMetricsProvider(io_task_runner_)));
+          new ::metrics::NetworkMetricsProvider(
+              nullptr /* network_quality_task_runner */,
+              nullptr /* network_quality_estimator_provider */,

[Alexei Svitkine (slow), 2017/01/04 15:18:59]

Up to you, but you can add a ctor override that doesn't take the two new params
- then you don't have to change these other call sites.

[tbansal1, 2017/01/04 20:47:54]

Done.

+              io_task_runner_)));
   metrics_service_->RegisterMetricsProvider(
       std::unique_ptr<::metrics::MetricsProvider>(
           new ::metrics::ProfilerMetricsProvider));
   shell::CastBrowserProcess::GetInstance()->browser_client()->
       RegisterMetricsProviders(metrics_service_.get());
 
   metrics_service_->InitializeMetricsRecordingState();
 #if !defined(OS_ANDROID)
   // Reset clean_shutdown bit after InitializeMetricsRecordingState().
   metrics_service_->LogNeedForCleanShutdown();
@@ skipping 27 matching lines @@
   external_metrics_->StopAndDestroy();
   external_metrics_ = nullptr;
   platform_metrics_->StopAndDestroy();
   platform_metrics_ = nullptr;
 #endif  // defined(OS_LINUX)
   metrics_service_->Stop();
 }
 
 }  // namespace metrics
 }  // namespace chromecast