Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2605543002: Replace adjustment of previous visual rects on scroll with normal paint invalidation (Closed)
Patch Set: Remove unused parameters Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index be913bda96355836de374231f5630bf74456b949..77f8743316317c6bcf66c7f7170762e1e70cac71 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -1911,8 +1911,7 @@ void FrameView::didScrollTimerFired(TimerBase*) {
m_frame->document()->fetcher()->updateAllImageResourcePriorities();
}
-void FrameView::updateLayersAndCompositingAfterScrollIfNeeded(
- const ScrollOffset& scrollDelta) {
+void FrameView::updateLayersAndCompositingAfterScrollIfNeeded() {
// Nothing to do after scrolling if there are no fixed position elements.
if (!hasViewportConstrainedObjects())
return;
@@ -1925,7 +1924,8 @@ void FrameView::updateLayersAndCompositingAfterScrollIfNeeded(
// TODO(skobes): Resolve circular dependency between scroll offset and
// compositing state, and remove this disabler. https://crbug.com/420741
DisableCompositingQueryAsserts disabler;
- layer->updateLayerPositionsAfterOverflowScroll(scrollDelta);
+ layer->updateLayerPositionsAfterOverflowScroll();
+ layoutObject->setMayNeedPaintInvalidationSubtree();
}
}
@@ -3804,7 +3804,7 @@ void FrameView::updateScrollOffset(const ScrollOffset& offset,
if (scrollTypeClearsFragmentAnchor(scrollType))
clearFragmentAnchor();
- updateLayersAndCompositingAfterScrollIfNeeded(scrollDelta);
+ updateLayersAndCompositingAfterScrollIfNeeded();
Document* document = m_frame->document();
document->enqueueScrollEventForNode(document);
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.h ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698