Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: media/renderers/renderer_impl.h

Issue 2605473002: Fix processing of multiple stream status changes by renderer (Closed)
Patch Set: Use a queue of postponed notifications + CR feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/renderers/renderer_impl.cc » ('j') | media/renderers/renderer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/renderers/renderer_impl.h
diff --git a/media/renderers/renderer_impl.h b/media/renderers/renderer_impl.h
index 07ea2241cfb145ede0b0a233e3adc779bdcf1a23..be533945aff7f1747a641e5675b79bed1eea75ce 100644
--- a/media/renderers/renderer_impl.h
+++ b/media/renderers/renderer_impl.h
@@ -6,6 +6,7 @@
#define MEDIA_RENDERERS_RENDERER_IMPL_H_
#include <memory>
+#include <queue>
#include <vector>
#include "base/cancelable_callback.h"
@@ -60,7 +61,7 @@ class MEDIA_EXPORT RendererImpl : public Renderer {
void SetVolume(float volume) final;
base::TimeDelta GetMediaTime() final;
- void RestartStreamPlayback(DemuxerStream* stream,
+ void OnStreamStatusChanged(DemuxerStream* stream,
bool enabled,
base::TimeDelta time);
@@ -196,7 +197,9 @@ class MEDIA_EXPORT RendererImpl : public Renderer {
base::TimeDelta video_underflow_threshold_;
bool restarting_audio_ = false;
+ std::queue<base::Closure> postponed_audio_status_notifications_;
xhwang 2017/01/04 22:04:16 tiny nit: - typically we use "pending" instead of
servolk 2017/01/05 02:38:45 Done.
bool restarting_video_ = false;
+ std::queue<base::Closure> postponed_video_status_notifications_;
base::WeakPtr<RendererImpl> weak_this_;
base::WeakPtrFactory<RendererImpl> weak_factory_;
« no previous file with comments | « no previous file | media/renderers/renderer_impl.cc » ('j') | media/renderers/renderer_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698