Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp

Issue 2605413002: MHTML generation: discard serialized resources by the measure they are encoded. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp b/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp
index 37199c58ed05d222faa1e9b31a04970a03accbb4..bb8ea51e4cb7908b245909db458c2829c42d7cb1 100644
--- a/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp
+++ b/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp
@@ -48,6 +48,7 @@
#include "web/WebViewImpl.h"
#include "web/tests/FrameTestHelpers.h"
#include "wtf/Assertions.h"
+#include "wtf/Deque.h"
#include "wtf/Vector.h"
using blink::URLTestHelpers::toKURL;
@@ -125,12 +126,11 @@ class FrameSerializerTest : public testing::Test,
}
}
- Vector<SerializedResource>& getResources() { return m_resources; }
+ Deque<SerializedResource>& getResources() { return m_resources; }
const SerializedResource* getResource(const KURL& url, const char* mimeType) {
String mime(mimeType);
- for (size_t i = 0; i < m_resources.size(); ++i) {
- const SerializedResource& resource = m_resources[i];
+ for (const SerializedResource& resource : m_resources) {
if (resource.url == url && !resource.data->isEmpty() &&
(mime.isNull() || equalIgnoringASCIICase(resource.mimeType, mime)))
return &resource;
@@ -190,7 +190,7 @@ class FrameSerializerTest : public testing::Test,
FrameTestHelpers::WebViewHelper m_helper;
WebString m_folder;
KURL m_baseUrl;
- Vector<SerializedResource> m_resources;
+ Deque<SerializedResource> m_resources;
HashMap<String, String> m_rewriteURLs;
Vector<String> m_skipURLs;
String m_rewriteFolder;

Powered by Google App Engine
This is Rietveld 408576698