chrome/browser/safe_browsing/certificate_reporting_service_factory.h - Issue 2605403002: Fix flaky CertificateReportingService browser tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/certificate_reporting_service_factory.h

Issue 2605403002: Fix flaky CertificateReportingService browser tests. (Closed)

Patch Set: estark comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc ('k') | chrome/browser/safe_browsing/certificate_reporting_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/certificate_reporting_service_factory.h

diff --git a/chrome/browser/safe_browsing/certificate_reporting_service_factory.h b/chrome/browser/safe_browsing/certificate_reporting_service_factory.h

index fe18a5ad912748d387cedb875bc084058c730329..63535db6be65d8c662a68e708a3d5d1dfce13dac 100644

--- a/chrome/browser/safe_browsing/certificate_reporting_service_factory.h

+++ b/chrome/browser/safe_browsing/certificate_reporting_service_factory.h

@@ -30,6 +30,8 @@ class CertificateReportingServiceFactory

void SetClockForTesting(std::unique_ptr<base::Clock> clock);

void SetQueuedReportTTLForTesting(base::TimeDelta queued_report_ttl);

void SetMaxQueuedReportCountForTesting(size_t max_report_count);

+ void SetServiceResetCallbackForTesting(

+ const base::Callback<void()>& service_reset_callback);

private:

friend struct base::DefaultSingletonTraits<

@@ -51,6 +53,7 @@ class CertificateReportingServiceFactory

std::unique_ptr<base::Clock> clock_;

base::TimeDelta queued_report_ttl_;

size_t max_queued_report_count_;

+ base::Callback<void()> service_reset_callback_;

DISALLOW_COPY_AND_ASSIGN(CertificateReportingServiceFactory);

};