Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: components/sync/syncable/model_type.cc

Issue 2605393002: Move syncer::kModelTypeInfoMap array to read-only data segment (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/syncable/model_type.cc
diff --git a/components/sync/syncable/model_type.cc b/components/sync/syncable/model_type.cc
index a4d34f19a63f44ad37423129f479115dd3a8fe75..363c848d728a4276d94e84e054389069a2190f54 100644
--- a/components/sync/syncable/model_type.cc
+++ b/components/sync/syncable/model_type.cc
@@ -31,23 +31,23 @@
namespace syncer {
struct ModelTypeInfo {
- const ModelType model_type;
+ ModelType model_type;
// Model Type notification string.
// This needs to match the corresponding proto message name in sync.proto
- const char* const notification_type;
+ const char* notification_type;
// Root tag for Model Type
// This should be the same as the model type but all lowercase.
- const char* const root_tag;
+ const char* root_tag;
// String value for Model Type
// This should be the same as the model type but space separated and the
// first letter of every word capitalized.
- const char* const model_type_string;
+ const char* model_type_string;
// SpecificsFieldNumber for Model Type
- const int specifics_field_number;
+ int specifics_field_number;
// Histogram value should be unique for the Model Type, Existing histogram
// values should never be modified without updating "SyncModelTypes" enum in
// histograms.xml to maintain backward compatibility.
- const int model_type_histogram_val;
+ int model_type_histogram_val;
};
// Below struct entries are in the same order as their definition in the
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698