Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 260533002: Fix Crash Due to Programmatic Dismissal of a Notification. (Closed)

Created:
6 years, 7 months ago by skare_
Modified:
6 years, 7 months ago
Reviewers:
robliao, dewittj
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix Crash Due to Programmatic Dismissal of a Notification. The notification dismissal was reported as from a user, which is not the case when the notification is dismissed programmatically. BUG=368405 R=dewittj@chromium.org, robliao@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/notifications/extension_welcome_notification.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
skare_
6 years, 7 months ago (2014-04-29 19:51:49 UTC) #1
robliao
lgtm
6 years, 7 months ago (2014-04-29 19:52:31 UTC) #2
robliao
6 years, 7 months ago (2014-04-29 19:59:56 UTC) #3
skare_
+dewittj for OWNERS
6 years, 7 months ago (2014-04-29 20:00:06 UTC) #4
dewittj
nit: better issue description for more commit message love. And bug #. Other than that, ...
6 years, 7 months ago (2014-04-29 20:33:00 UTC) #5
robliao
On 2014/04/29 20:33:00, dewittj wrote: > nit: better issue description for more commit message love. ...
6 years, 7 months ago (2014-04-29 20:33:47 UTC) #6
robliao
Updated the Changelist Description
6 years, 7 months ago (2014-04-29 20:40:36 UTC) #7
robliao
On 2014/04/29 20:40:36, robliao wrote: > Updated the Changelist Description D:\src>out\Debug\unit_tests.exe --single-process-tests --gtest_filter=ExtensionWelcome* [==========] 12 ...
6 years, 7 months ago (2014-04-29 20:46:03 UTC) #8
robliao
6 years, 7 months ago (2014-04-29 20:49:54 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r266956 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698