content/browser/blob_storage/blob_storage_context_unittest.cc - Issue 2605293002: Add WARN_UNUSED_RESULT to base::Time methods that return bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/blob_storage/blob_storage_context_unittest.cc

Issue 2605293002: Add WARN_UNUSED_RESULT to base::Time methods that return bool. (Closed)

Patch Set: Fix ChromeOS unit-test Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/blob_storage/blob_storage_context_unittest.cc

diff --git a/content/browser/blob_storage/blob_storage_context_unittest.cc b/content/browser/blob_storage/blob_storage_context_unittest.cc

index 44f18db2fd9b6028f7620a671ee1783e41cdfa99..55ff1408038b6c272edd34850d55e91271b9da54 100644

--- a/content/browser/blob_storage/blob_storage_context_unittest.cc

+++ b/content/browser/blob_storage/blob_storage_context_unittest.cc

@@ -590,8 +590,8 @@ TEST_F(BlobStorageContextTest, CompoundBlobs) {

// Setup a set of blob data for testing.

base::Time time1, time2;

- base::Time::FromString("Tue, 15 Nov 1994, 12:45:26 GMT", &time1);

- base::Time::FromString("Mon, 14 Nov 1994, 11:30:49 GMT", &time2);

+ ASSERT_TRUE(base::Time::FromString("Tue, 15 Nov 1994, 12:45:26 GMT", &time1));

+ ASSERT_TRUE(base::Time::FromString("Mon, 14 Nov 1994, 11:30:49 GMT", &time2));

BlobDataBuilder blob_data1(kId1);

blob_data1.AppendData("Data1");