net/http/http_response_headers_unittest.cc - Issue 2605293002: Add WARN_UNUSED_RESULT to base::Time methods that return bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_response_headers_unittest.cc

Issue 2605293002: Add WARN_UNUSED_RESULT to base::Time methods that return bool. (Closed)

Patch Set: Add comment to PexeDownloader::didReceiveResponse() Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_response_headers_unittest.cc

diff --git a/net/http/http_response_headers_unittest.cc b/net/http/http_response_headers_unittest.cc

index 2f2f7befb05e9b7eed94adcc7a71a8760e14fc1b..f24d1830470c5f7582148f18a8e6990bff26da68 100644

--- a/net/http/http_response_headers_unittest.cc

+++ b/net/http/http_response_headers_unittest.cc

@@ -780,9 +780,12 @@ TEST_P(RequiresValidationTest, RequiresValidation) {

const RequiresValidationTestData test = GetParam();

base::Time request_time, response_time, current_time;

- base::Time::FromString("Wed, 28 Nov 2007 00:40:09 GMT", &request_time);

- base::Time::FromString("Wed, 28 Nov 2007 00:40:12 GMT", &response_time);

- base::Time::FromString("Wed, 28 Nov 2007 00:45:20 GMT", &current_time);

+ ASSERT_TRUE(

+ base::Time::FromString("Wed, 28 Nov 2007 00:40:09 GMT", &request_time));

+ ASSERT_TRUE(

+ base::Time::FromString("Wed, 28 Nov 2007 00:40:12 GMT", &response_time));

+ ASSERT_TRUE(

+ base::Time::FromString("Wed, 28 Nov 2007 00:45:20 GMT", &current_time));

std::string headers(test.headers);

HeadersToRaw(&headers);