Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: components/nacl/browser/pnacl_translation_cache_unittest.cc

Issue 2605293002: Add WARN_UNUSED_RESULT to base::Time methods that return bool. (Closed)
Patch Set: Add comment to PexeDownloader::didReceiveResponse() Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/browser/pnacl_translation_cache_unittest.cc
diff --git a/components/nacl/browser/pnacl_translation_cache_unittest.cc b/components/nacl/browser/pnacl_translation_cache_unittest.cc
index dfc3bdefc6372d99051ff342a2c6b587ee2fa03b..057ef96ee1a65b08c847907231f1f0ccf3cc4278 100644
--- a/components/nacl/browser/pnacl_translation_cache_unittest.cc
+++ b/components/nacl/browser/pnacl_translation_cache_unittest.cc
@@ -135,7 +135,7 @@ TEST(PnaclTranslationCacheKeyTest, CacheKeyTest) {
info.opt_level = 0;
info.sandbox_isa = "x86-32";
std::string test_time("Wed, 15 Nov 1995 06:25:24 GMT");
- base::Time::FromString(test_time.c_str(), &info.last_modified);
+ EXPECT_TRUE(base::Time::FromString(test_time.c_str(), &info.last_modified));
// Basic check for URL and time components
EXPECT_EQ("ABI:0;opt:0;URL:http://www.google.com/;"
"modified:1995:11:15:6:25:24:0:UTC;etag:;"
@@ -204,7 +204,7 @@ TEST(PnaclTranslationCacheKeyTest, CacheKeyTest) {
"sandbox:x86-32;extra_flags:-mavx-neon;",
PnaclTranslationCache::GetKey(info));
test_time.assign("Fri, 29 Feb 2008 13:04:12 GMT");
- base::Time::FromString(test_time.c_str(), &info.last_modified);
+ EXPECT_TRUE(base::Time::FromString(test_time.c_str(), &info.last_modified));
EXPECT_EQ("ABI:2;opt:2;URL:http://www.google.com/;"
"modified:2008:2:29:13:4:12:0:UTC;etag:etag;"
"sandbox:x86-32;extra_flags:-mavx-neon;",

Powered by Google App Engine
This is Rietveld 408576698