components/metrics/data_use_tracker.cc - Issue 2605293002: Add WARN_UNUSED_RESULT to base::Time methods that return bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/data_use_tracker.cc

Issue 2605293002: Add WARN_UNUSED_RESULT to base::Time methods that return bool. (Closed)

Patch Set: Add comment to PexeDownloader::didReceiveResponse() Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/data_use_tracker.cc

diff --git a/components/metrics/data_use_tracker.cc b/components/metrics/data_use_tracker.cc

index b9b9bda08a96672a3ce32723b3e4e4e1f8fdbfe3..6081facf5d6c068bdbf782c5fd05d7890e1b263b 100644

--- a/components/metrics/data_use_tracker.cc

+++ b/components/metrics/data_use_tracker.cc

@@ -118,8 +118,8 @@ void DataUseTracker::RemoveExpiredEntriesForPref(const std::string& pref_name) {

for (base::DictionaryValue::Iterator it(*user_pref_dict); !it.IsAtEnd();

it.Advance()) {

base::Time key_date;

- base::Time::FromUTCString(it.key().c_str(), &key_date);

- if (key_date > week_ago)

+ if (base::Time::FromUTCString(it.key().c_str(), &key_date) &&

+ key_date > week_ago)

user_pref_new_dict.Set(it.key(), it.value().CreateDeepCopy());

}

local_state_->Set(pref_name, user_pref_new_dict);