Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4306)

Unified Diff: chrome/browser/chromeos/mobile_config_unittest.cc

Issue 2605293002: Add WARN_UNUSED_RESULT to base::Time methods that return bool. (Closed)
Patch Set: Add comment to PexeDownloader::didReceiveResponse() Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/mobile_config_unittest.cc
diff --git a/chrome/browser/chromeos/mobile_config_unittest.cc b/chrome/browser/chromeos/mobile_config_unittest.cc
index abd399201c1401a5820c7d00dac91a0dcd5f1092..9b4fe878927c6f403726edbf53ad8a8433d7fbda 100644
--- a/chrome/browser/chromeos/mobile_config_unittest.cc
+++ b/chrome/browser/chromeos/mobile_config_unittest.cc
@@ -147,7 +147,7 @@ TEST(MobileConfigTest, Basic) {
deal->GetLocalizedString("en", "notification_text"));
base::Time reference_time;
- base::Time::FromString("31/12/2099 0:00", &reference_time);
+ EXPECT_TRUE(base::Time::FromString("31/12/2099 0:00", &reference_time));
EXPECT_EQ(reference_time, deal->expire_date());
const MobileConfig::LocaleConfig* locale_config;
@@ -232,7 +232,7 @@ TEST(MobileConfigTest, LocalConfig) {
EXPECT_EQ("default_text from local.",
deal->GetLocalizedString("en", "notification_text"));
base::Time reference_time;
- base::Time::FromString("31/12/2099 0:00", &reference_time);
+ EXPECT_TRUE(base::Time::FromString("31/12/2099 0:00", &reference_time));
EXPECT_EQ(reference_time, deal->expire_date());
// Now reload same global/local config files but with proper initial locale.

Powered by Google App Engine
This is Rietveld 408576698