Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: components/nacl/renderer/ppb_nacl_private_impl.cc

Issue 2605293002: Add WARN_UNUSED_RESULT to base::Time methods that return bool. (Closed)
Patch Set: Better use of EXPECT_TRUE in unit-tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/renderer/ppb_nacl_private_impl.cc
diff --git a/components/nacl/renderer/ppb_nacl_private_impl.cc b/components/nacl/renderer/ppb_nacl_private_impl.cc
index d39b2b701e22b1567a8ed474a2c7ae06e1e05e7a..7f4785a7f3ac33f3a54467162d3ce28f01583d1e 100644
--- a/components/nacl/renderer/ppb_nacl_private_impl.cc
+++ b/components/nacl/renderer/ppb_nacl_private_impl.cc
@@ -1623,7 +1623,8 @@ class PexeDownloader : public blink::WebAssociatedURLLoaderClient {
std::string last_modified =
response.httpHeaderField("last-modified").utf8();
base::Time last_modified_time;
- base::Time::FromString(last_modified.c_str(), &last_modified_time);
+ ignore_result(
miu 2017/01/10 04:02:42 Did we check what downstream code will do if |last
digit1 2017/01/10 13:55:58 I've checked downstream that the only user for thi
+ base::Time::FromString(last_modified.c_str(), &last_modified_time));
bool has_no_store_header = false;
std::string cache_control =
« no previous file with comments | « components/nacl/browser/pnacl_translation_cache_unittest.cc ('k') | components/variations/variations_seed_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698