components/nacl/renderer/ppb_nacl_private_impl.cc - Issue 2605293002: Add WARN_UNUSED_RESULT to base::Time methods that return bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/renderer/ppb_nacl_private_impl.cc

Issue 2605293002: Add WARN_UNUSED_RESULT to base::Time methods that return bool. (Closed)

Patch Set: Use ASSERT_TRUE in unit test Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/renderer/ppb_nacl_private_impl.cc

diff --git a/components/nacl/renderer/ppb_nacl_private_impl.cc b/components/nacl/renderer/ppb_nacl_private_impl.cc

index d39b2b701e22b1567a8ed474a2c7ae06e1e05e7a..7f4785a7f3ac33f3a54467162d3ce28f01583d1e 100644

--- a/components/nacl/renderer/ppb_nacl_private_impl.cc

+++ b/components/nacl/renderer/ppb_nacl_private_impl.cc

@@ -1623,7 +1623,8 @@ class PexeDownloader : public blink::WebAssociatedURLLoaderClient {

std::string last_modified =

response.httpHeaderField("last-modified").utf8();

base::Time last_modified_time;

- base::Time::FromString(last_modified.c_str(), &last_modified_time);

+ ignore_result(

+ base::Time::FromString(last_modified.c_str(), &last_modified_time));

bool has_no_store_header = false;

std::string cache_control =