Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc

Issue 2605293002: Add WARN_UNUSED_RESULT to base::Time methods that return bool. (Closed)
Patch Set: Use ASSERT_TRUE in unit test Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/mobile_config_unittest.cc ('k') | components/metrics/data_use_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
index 35ec52fb31ec81fde244767f660da2db94e86f06..6e2acb62bede2735801fe3377ff0e422d9c07147 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
@@ -11,6 +11,7 @@
#include <utility>
#include "base/command_line.h"
+#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
#include "base/run_loop.h"
@@ -114,7 +115,7 @@ const char kLastUpdateTime[] = "Wed, 18 Sep 2013 03:45:26";
class DataReductionProxyCompressionStatsTest : public testing::Test {
protected:
DataReductionProxyCompressionStatsTest() {
- base::Time::FromString(kLastUpdateTime, &now_);
+ ignore_result(base::Time::FromString(kLastUpdateTime, &now_));
Nico 2017/01/03 19:00:38 this can probably be EXPECT_TRUE too?
digit1 2017/01/05 10:26:28 Good point, I've changed that too. Thanks :)
}
void SetUp() override {
« no previous file with comments | « chrome/browser/chromeos/mobile_config_unittest.cc ('k') | components/metrics/data_use_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698