Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

Issue 2605283002: [Android] Change items shown in context meanu for mailto link (Closed)
Patch Set: Update based on Ted's comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/android/java/strings/android_chrome_strings.grd ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java ('k') | chrome/test/data/android/contextmenu/context_menu_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
index 3c25a62d517bb7dd68005afecdfd9c05baf06f75..f77397ea1bd6ce1774b157fef220b113a0b07598 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
@@ -295,11 +295,13 @@ public class CustomTabActivityTest extends CustomTabActivityTestBase {
public void testContextMenuEntriesForImage() throws InterruptedException, TimeoutException {
startCustomTabActivityWithIntent(createMinimalCustomTabIntent());
- final int expectedMenuSize = 9;
+ final int expectedMenuSize = 11;
Menu menu = ContextMenuUtils.openContextMenu(this, getActivity().getActivityTab(), "logo");
assertEquals(expectedMenuSize, menu.size());
assertNotNull(menu.findItem(R.id.contextmenu_copy_link_address));
+ assertNotNull(menu.findItem(R.id.contextmenu_send_message));
+ assertNotNull(menu.findItem(R.id.contextmenu_add_to_contacts));
assertNotNull(menu.findItem(R.id.contextmenu_copy_email_address));
assertNotNull(menu.findItem(R.id.contextmenu_copy_link_text));
assertNotNull(menu.findItem(R.id.contextmenu_save_link_as));
@@ -314,6 +316,8 @@ public class CustomTabActivityTest extends CustomTabActivityTestBase {
assertTrue(menu.findItem(R.id.contextmenu_search_by_image).isVisible());
assertFalse(menu.findItem(R.id.contextmenu_copy_link_address).isVisible());
+ assertFalse(menu.findItem(R.id.contextmenu_send_message).isVisible());
+ assertFalse(menu.findItem(R.id.contextmenu_add_to_contacts).isVisible());
assertFalse(menu.findItem(R.id.contextmenu_copy_email_address).isVisible());
assertFalse(menu.findItem(R.id.contextmenu_copy_link_text).isVisible());
assertFalse(menu.findItem(R.id.contextmenu_save_link_as).isVisible());
@@ -330,12 +334,14 @@ public class CustomTabActivityTest extends CustomTabActivityTestBase {
public void testContextMenuEntriesForLink() throws InterruptedException, TimeoutException {
startCustomTabActivityWithIntent(createMinimalCustomTabIntent());
- final int expectedMenuSize = 9;
+ final int expectedMenuSize = 11;
Menu menu = ContextMenuUtils.openContextMenu(this, getActivity().getActivityTab(),
"aboutLink");
assertEquals(expectedMenuSize, menu.size());
assertNotNull(menu.findItem(R.id.contextmenu_copy_link_address));
+ assertNotNull(menu.findItem(R.id.contextmenu_send_message));
+ assertNotNull(menu.findItem(R.id.contextmenu_add_to_contacts));
assertNotNull(menu.findItem(R.id.contextmenu_copy_email_address));
assertNotNull(menu.findItem(R.id.contextmenu_copy_link_text));
assertNotNull(menu.findItem(R.id.contextmenu_save_link_as));
@@ -349,6 +355,8 @@ public class CustomTabActivityTest extends CustomTabActivityTestBase {
assertTrue(menu.findItem(R.id.contextmenu_save_link_as).isVisible());
assertFalse(menu.findItem(R.id.contextmenu_share_image).isVisible());
+ assertFalse(menu.findItem(R.id.contextmenu_send_message).isVisible());
+ assertFalse(menu.findItem(R.id.contextmenu_add_to_contacts).isVisible());
assertFalse(menu.findItem(R.id.contextmenu_copy_email_address).isVisible());
assertFalse(menu.findItem(R.id.contextmenu_save_image).isVisible());
assertFalse(menu.findItem(R.id.contextmenu_open_image).isVisible());
@@ -357,6 +365,44 @@ public class CustomTabActivityTest extends CustomTabActivityTestBase {
}
/**
+ * Test the entries in the context menu shown when long clicking an mailto url.
+ * @SmallTest
+ * @RetryOnFailure
+ */
+ @DisabledTest
+ public void testContextMenuEntriesForMailto() throws InterruptedException, TimeoutException {
+ startCustomTabActivityWithIntent(createMinimalCustomTabIntent());
+
+ final int expectedMenuSize = 11;
+ Menu menu = ContextMenuUtils.openContextMenu(this, getActivity().getActivityTab(), "email");
+ assertEquals(expectedMenuSize, menu.size());
+
+ assertNotNull(menu.findItem(R.id.contextmenu_copy_link_address));
+ assertNotNull(menu.findItem(R.id.contextmenu_send_message));
+ assertNotNull(menu.findItem(R.id.contextmenu_add_to_contacts));
+ assertNotNull(menu.findItem(R.id.contextmenu_copy_email_address));
+ assertNotNull(menu.findItem(R.id.contextmenu_copy_link_text));
+ assertNotNull(menu.findItem(R.id.contextmenu_save_link_as));
+ assertNotNull(menu.findItem(R.id.contextmenu_save_image));
+ assertNotNull(menu.findItem(R.id.contextmenu_share_image));
+ assertNotNull(menu.findItem(R.id.contextmenu_open_image));
+ assertNotNull(menu.findItem(R.id.contextmenu_save_video));
+
+ assertTrue(menu.findItem(R.id.contextmenu_send_message).isVisible());
+ assertTrue(menu.findItem(R.id.contextmenu_add_to_contacts).isVisible());
+ assertTrue(menu.findItem(R.id.contextmenu_copy_email_address).isVisible());
+
+ assertFalse(menu.findItem(R.id.contextmenu_copy_link_address).isVisible());
+ assertFalse(menu.findItem(R.id.contextmenu_save_image).isVisible());
+ assertFalse(menu.findItem(R.id.contextmenu_share_image).isVisible());
+ assertFalse(menu.findItem(R.id.contextmenu_open_image).isVisible());
+ assertFalse(menu.findItem(R.id.contextmenu_search_by_image).isVisible());
+ assertFalse(menu.findItem(R.id.contextmenu_copy_link_text).isVisible());
+ assertFalse(menu.findItem(R.id.contextmenu_save_link_as).isVisible());
+ assertFalse(menu.findItem(R.id.contextmenu_save_video).isVisible());
+ }
+
+ /**
* Test the entries in the app menu.
*/
@SmallTest
« chrome/android/java/strings/android_chrome_strings.grd ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java ('k') | chrome/test/data/android/contextmenu/context_menu_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698