Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-fixed-height.js

Issue 2605253002: [DevTools] Add grow mode to ListControl. (Closed)
Patch Set: addressed review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-fixed-height-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-fixed-height.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-fixed-height.js b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-fixed-height.js
index 05920c6884c57bc23c2744ce935c00b74e8b46ad..c5bb691e7f29e519980dc1c03151e796eb70aa15 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-fixed-height.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-fixed-height.js
@@ -31,8 +31,7 @@ class Delegate {
}
var delegate = new Delegate();
-var list = new UI.ListControl(delegate);
-list.setHeightMode(UI.ListHeightMode.Fixed);
+var list = new UI.ListControl(delegate, UI.ListMode.ViewportFixedItems);
list.element.style.height = '73px';
UI.inspectorView.element.appendChild(list.element);
@@ -137,9 +136,9 @@ TestRunner.addResult('Scrolling to 13');
list.scrollItemAtIndexIntoView(13);
dumpList();
-TestRunner.addResult('Changing the item height, switching to measure');
+TestRunner.addResult('Changing the item height');
delegate.height = 15;
-list.setHeightMode(UI.ListHeightMode.Measured);
+list.fixedHeightChanged();
dumpList();
TestRunner.addResult('Selecting 7');
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-fixed-height-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698