Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

Issue 2605253002: [DevTools] Add grow mode to ListControl. (Closed)
Patch Set: works Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/devtools/front_end/ui/ListControl.js ('K') | « third_party/WebKit/Source/devtools/front_end/ui/ListControl.js ('k') | third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js b/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js
index 2492af997336363ffa703874f4cb32294c14892a..cd125efcae71f5738a23610804c3b57d5b4eecee 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js
@@ -386,7 +386,7 @@ UI.SuggestBox = class {
this._updateBoxPosition(anchorBox, completions.length);
this._updateWidth(completions);
- this._list.setHeightMode(UI.ListHeightMode.Fixed);
+ this._list.setMode(UI.ListMode.ViewportFixedItems);
caseq 2016/12/29 19:25:31 let's have a dedicated method to reset height?
this._list.replaceAllItems(completions);
var highestPriorityItem = -1;
« third_party/WebKit/Source/devtools/front_end/ui/ListControl.js ('K') | « third_party/WebKit/Source/devtools/front_end/ui/ListControl.js ('k') | third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698