Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-grow.js

Issue 2605253002: [DevTools] Add grow mode to ListControl. (Closed)
Patch Set: works Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-grow.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-variable-height.js b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-grow.js
similarity index 79%
copy from third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-variable-height.js
copy to third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-grow.js
index bc49549bc6576d24c821225e0fddfeb71a6bf330..52f6c4dbbae2181856ed58005701d64a66031017 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-variable-height.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-grow.js
@@ -1,4 +1,4 @@
-TestRunner.addResult('Test ListControl rendering for variable height case.');
+TestRunner.addResult('Test ListControl rendering and selection for grow mode.');
class Delegate {
constructor() {
@@ -7,13 +7,14 @@ class Delegate {
createElementForItem(item) {
TestRunner.addResult('Creating element for ' + item);
var element = document.createElement('div');
- element.style.height = this.heightForItem(item) + 'px';
+ element.style.height = (10 + item % 5) + 'px';
element.textContent = item;
return element;
}
heightForItem(item) {
- return 7 + item % 10;
+ TestRunner.addResult('heightForItem should not be called');
+ return 10 + item % 5;
}
isItemSelectable(item) {
@@ -31,8 +32,7 @@ class Delegate {
var delegate = new Delegate();
var list = new UI.ListControl(delegate);
-list.setHeightMode(UI.ListHeightMode.Variable);
-list.element.style.height = '73px';
+list.setMode(UI.ListMode.Grow);
UI.inspectorView.element.appendChild(list.element);
function dumpList()
@@ -48,7 +48,6 @@ function dumpList()
var text = child === list._topElement ? 'top' : (child === list._bottomElement ? 'bottom' : child.textContent);
TestRunner.addResult(`${visible}[${offsetTop}] ${text}${selected}`);
}
- TestRunner.addResult('offsets: ' + list._variableOffsets.join(' '));
TestRunner.addResult('');
}
@@ -68,22 +67,10 @@ TestRunner.addResult('Adding 3-20');
list.replaceItemsInRange(3, 3, [3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19]);
dumpList();
-TestRunner.addResult('Scrolling to 11');
-list.scrollItemAtIndexIntoView(11);
-dumpList();
-
TestRunner.addResult('Scrolling to 19');
list.scrollItemAtIndexIntoView(19);
dumpList();
-TestRunner.addResult('Scrolling to 16');
-list.scrollItemAtIndexIntoView(16);
-dumpList();
-
-TestRunner.addResult('Scrolling to 3');
-list.scrollItemAtIndexIntoView(3);
-dumpList();
-
TestRunner.addResult('Replacing 0, 1 with 25-36');
list.replaceItemsInRange(0, 2, [25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36]);
dumpList();
@@ -108,9 +95,4 @@ TestRunner.addResult('Replacing 45 with 16-18');
list.replaceItemsInRange(16, 17, [16, 17, 18]);
dumpList();
-TestRunner.addResult('Resizing');
-list.element.style.height = '190px';
-list.viewportResized();
-dumpList();
-
TestRunner.completeTest();

Powered by Google App Engine
This is Rietveld 408576698