Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 2605213002: componentize SafeBrowsingService (Closed)
Patch Set: Remove explicit return statements Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_service.h ('k') | components/safe_browsing/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_service.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc
index d124f5a5afa72b017b5e3bbc8227dce09df5b740..151e73292b06627d1001ce35002e3a5e2a8ead6c 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc
@@ -286,7 +286,6 @@ SafeBrowsingService* SafeBrowsingService::CreateSafeBrowsingService() {
SafeBrowsingService::SafeBrowsingService()
: services_delegate_(ServicesDelegate::Create(this)),
- enabled_(false),
enabled_by_prefs_(false),
enabled_v4_only_(safe_browsing::V4FeatureList::IsV4OnlyEnabled()) {}
@@ -393,6 +392,8 @@ SafeBrowsingService::url_request_context() {
return url_request_context_getter_;
}
+// TODO(ntfschr): componentize this once BaseSafeBrowsingUIManager contains a
+// SafeBrowsingService
const scoped_refptr<SafeBrowsingUIManager>&
SafeBrowsingService::ui_manager() const {
return ui_manager_;
@@ -463,6 +464,8 @@ void SafeBrowsingService::OnResourceRequest(const net::URLRequest* request) {
#endif
}
+// TODO(ntfschr): componentize this once BaseSafeBrowsingUIManager contains a
+// SafeBrowsingService
SafeBrowsingUIManager* SafeBrowsingService::CreateUIManager() {
return new SafeBrowsingUIManager(this);
}
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_service.h ('k') | components/safe_browsing/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698