Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: third_party/WebKit/Source/core/html/HTMLStyleElement.h

Issue 2605173002: Call checkCompleted() synchronously in HTMLStyleElement::dispatchPendingEvent() (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLStyleElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLStyleElement.h b/third_party/WebKit/Source/core/html/HTMLStyleElement.h
index 40cc8c51283426649a2583a9353b84e1c041566c..739fb2f04ce5d911a18bc5257e42969d99a4cd5f 100644
--- a/third_party/WebKit/Source/core/html/HTMLStyleElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLStyleElement.h
@@ -44,13 +44,15 @@ class CORE_EXPORT HTMLStyleElement final : public HTMLElement,
bool disabled() const;
void setDisabled(bool);
- void dispatchPendingEvent(std::unique_ptr<IncrementLoadEventDelayCount>);
-
DECLARE_VIRTUAL_TRACE();
private:
HTMLStyleElement(Document&, bool createdByParser);
+ // Always call this asynchronously because this can cause synchronous
+ // Document load event and JavaScript execution.
+ void dispatchPendingEvent(std::unique_ptr<IncrementLoadEventDelayCount>);
+
// overload from HTMLElement
void parseAttribute(const AttributeModificationParams&) override;
InsertionNotificationRequest insertedInto(ContainerNode*) override;

Powered by Google App Engine
This is Rietveld 408576698