Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: Source/bindings/v8/V8Initializer.cpp

Issue 260513004: DevTools: [Console] fix sourceurl when exception happens before inspector is open (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 return; 99 return;
100 100
101 String errorMessage = toCoreString(message->Get()); 101 String errorMessage = toCoreString(message->Get());
102 102
103 v8::Handle<v8::StackTrace> stackTrace = message->GetStackTrace(); 103 v8::Handle<v8::StackTrace> stackTrace = message->GetStackTrace();
104 RefPtr<ScriptCallStack> callStack; 104 RefPtr<ScriptCallStack> callStack;
105 // Currently stack trace is only collected when inspector is open. 105 // Currently stack trace is only collected when inspector is open.
106 if (!stackTrace.IsEmpty() && stackTrace->GetFrameCount() > 0) 106 if (!stackTrace.IsEmpty() && stackTrace->GetFrameCount() > 0)
107 callStack = createScriptCallStack(stackTrace, ScriptCallStack::maxCallSt ackSizeToCapture, isolate); 107 callStack = createScriptCallStack(stackTrace, ScriptCallStack::maxCallSt ackSizeToCapture, isolate);
108 108
109 v8::Handle<v8::Value> resourceName = message->GetScriptResourceName(); 109 v8::Handle<v8::Value> resourceName = message->GetScriptResourceNameOrSourceU RL();
110 bool shouldUseDocumentURL = resourceName.IsEmpty() || !resourceName->IsStrin g(); 110 bool shouldUseDocumentURL = resourceName.IsEmpty() || !resourceName->IsStrin g();
111 String resource = shouldUseDocumentURL ? enteredWindow->document()->url() : toCoreString(resourceName.As<v8::String>()); 111 String resource = shouldUseDocumentURL ? enteredWindow->document()->url() : toCoreString(resourceName.As<v8::String>());
112 AccessControlStatus corsStatus = message->IsSharedCrossOrigin() ? SharableCr ossOrigin : NotSharableCrossOrigin; 112 AccessControlStatus corsStatus = message->IsSharedCrossOrigin() ? SharableCr ossOrigin : NotSharableCrossOrigin;
113 113
114 DOMWrapperWorld& world = DOMWrapperWorld::current(isolate); 114 DOMWrapperWorld& world = DOMWrapperWorld::current(isolate);
115 RefPtrWillBeRawPtr<ErrorEvent> event = ErrorEvent::create(errorMessage, reso urce, message->GetLineNumber(), message->GetStartColumn() + 1, &world); 115 RefPtrWillBeRawPtr<ErrorEvent> event = ErrorEvent::create(errorMessage, reso urce, message->GetLineNumber(), message->GetStartColumn() + 1, &world);
116 if (V8DOMWrapper::isDOMWrapper(data)) { 116 if (V8DOMWrapper::isDOMWrapper(data)) {
117 v8::Handle<v8::Object> obj = v8::Handle<v8::Object>::Cast(data); 117 v8::Handle<v8::Object> obj = v8::Handle<v8::Object>::Cast(data);
118 const WrapperTypeInfo* type = toWrapperTypeInfo(obj); 118 const WrapperTypeInfo* type = toWrapperTypeInfo(obj);
119 if (V8DOMException::wrapperTypeInfo.isSubclass(type)) { 119 if (V8DOMException::wrapperTypeInfo.isSubclass(type)) {
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 v8::V8::AddMessageListener(messageHandlerInWorker); 241 v8::V8::AddMessageListener(messageHandlerInWorker);
242 v8::V8::SetFatalErrorHandler(reportFatalErrorInWorker); 242 v8::V8::SetFatalErrorHandler(reportFatalErrorInWorker);
243 243
244 v8::ResourceConstraints resourceConstraints; 244 v8::ResourceConstraints resourceConstraints;
245 uint32_t here; 245 uint32_t here;
246 resourceConstraints.set_stack_limit(&here - kWorkerMaxStackSize / sizeof(uin t32_t*)); 246 resourceConstraints.set_stack_limit(&here - kWorkerMaxStackSize / sizeof(uin t32_t*));
247 v8::SetResourceConstraints(isolate, &resourceConstraints); 247 v8::SetResourceConstraints(isolate, &resourceConstraints);
248 } 248 }
249 249
250 } // namespace WebCore 250 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698