Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: tools/presubmit.py

Issue 2605113002: [test] Suppress new lint check (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2012 the V8 project authors. All rights reserved. 3 # Copyright 2012 the V8 project authors. All rights reserved.
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 # build/include_what_you_use: Started giving false positives for variables 55 # build/include_what_you_use: Started giving false positives for variables
56 # named "string" and "map" assuming that you needed to include STL headers. 56 # named "string" and "map" assuming that you needed to include STL headers.
57 # TODO(bmeurer): Fix and re-enable readability/check 57 # TODO(bmeurer): Fix and re-enable readability/check
58 # http://crrev.com/2199323003 relands. 58 # http://crrev.com/2199323003 relands.
59 59
60 LINT_RULES = """ 60 LINT_RULES = """
61 -build/header_guard 61 -build/header_guard
62 -build/include_what_you_use 62 -build/include_what_you_use
63 -build/namespaces 63 -build/namespaces
64 -readability/check 64 -readability/check
65 -readability/fn_size
65 +readability/streams 66 +readability/streams
66 -runtime/references 67 -runtime/references
67 """.split() 68 """.split()
68 69
69 LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]|^Done processing') 70 LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]|^Done processing')
70 FLAGS_LINE = re.compile("//\s*Flags:.*--([A-z0-9-])+_[A-z0-9].*\n") 71 FLAGS_LINE = re.compile("//\s*Flags:.*--([A-z0-9-])+_[A-z0-9].*\n")
71 72
72 TOOLS_PATH = dirname(abspath(__file__)) 73 TOOLS_PATH = dirname(abspath(__file__))
73 74
74 def CppLintWorker(command): 75 def CppLintWorker(command):
(...skipping 424 matching lines...) Expand 10 before | Expand all | Expand 10 after
499 print "Running status-files check..." 500 print "Running status-files check..."
500 success &= StatusFilesProcessor().RunOnPath(workspace) 501 success &= StatusFilesProcessor().RunOnPath(workspace)
501 if success: 502 if success:
502 return 0 503 return 0
503 else: 504 else:
504 return 1 505 return 1
505 506
506 507
507 if __name__ == '__main__': 508 if __name__ == '__main__':
508 sys.exit(Main()) 509 sys.exit(Main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698