third_party/WebKit/Source/core/layout/ng/ng_units.h - Issue 2605093002: Negative margin lengths are legal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_units.h

Issue 2605093002: Negative margin lengths are legal (Closed)

Patch Set: Reinstate size checks Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_units.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_units.h b/third_party/WebKit/Source/core/layout/ng/ng_units.h

index 235bf802d0040eec8001b2adecbef7c87dfcccdb..6c768d7916b05a5f7799712020bc1155250ed21e 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_units.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_units.h

@@ -348,8 +348,6 @@ struct CORE_EXPORT NGStaticPosition {

LayoutUnit margin_end) const {

DCHECK_GE(container_size, LayoutUnit());

DCHECK_GE(length, LayoutUnit());

- DCHECK_GE(margin_start, LayoutUnit());

- DCHECK_GE(margin_end, LayoutUnit());

if (position_matches)

return position;

else

« no previous file with comments | « no previous file | no next file » | no next file with comments »