Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: build/android/pylib/local/device/local_device_environment.py

Issue 2605083002: [android] Clean up test_runner.py arguments. (Closed)
Patch Set: bpastene comment from other review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/pylib/local/machine/local_machine_environment.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/local/device/local_device_environment.py
diff --git a/build/android/pylib/local/device/local_device_environment.py b/build/android/pylib/local/device/local_device_environment.py
index 461223147b09493a0f13e77cabedbb648fc7033c..257d0b4fdcd8f715530450b6f4bf1da7f7135e12 100644
--- a/build/android/pylib/local/device/local_device_environment.py
+++ b/build/android/pylib/local/device/local_device_environment.py
@@ -10,6 +10,7 @@ import shutil
import tempfile
import threading
+import devil_chromium
from devil import base_error
from devil.android import device_blacklist
from devil.android import device_errors
@@ -94,6 +95,15 @@ class LocalDeviceEnvironment(environment.Environment):
self._tool_name = args.tool
self._trace_output = args.trace_output
+ devil_chromium.Initialize(
+ output_directory=constants.GetOutDirectory(),
+ adb_path=args.adb_path)
+
+ # Some things such as Forwarder require ADB to be in the environment path.
+ adb_dir = os.path.dirname(constants.GetAdbPath())
mikecase (-- gone --) 2017/03/14 16:02:44 You have a TODO to remove existing callers of cons
jbudorick 2017/03/14 20:00:37 Good call. Done.
+ if adb_dir and adb_dir not in os.environ['PATH'].split(os.pathsep):
+ os.environ['PATH'] = adb_dir + os.pathsep + os.environ['PATH']
+
#override
def SetUp(self):
if self.trace_output:
« no previous file with comments | « no previous file | build/android/pylib/local/machine/local_machine_environment.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698