Issue 2605006: [Mac] Disable menu certain menu items when a modal dialog or sheet is present.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2605006: [Mac] Disable menu certain menu items when a modal dialog or sheet is present. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 12 months ago by Robert Sesek

Modified:
4 years ago

Reviewers:
pink

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

[Mac] Disable menu certain menu items when a modal dialog or sheet is present. BUG=28755, 41818 TEST=Chromium-->Clear Browsing Data. Cannot open NTP. Cannot open bookmark manager. Cannot open history. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48964

Total comments: 1

Created: 4 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -12 lines)			Patch
M	chrome/browser/app_controller_mac.h	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/app_controller_mac.mm	View	1 2 3 4	3 chunks	+24 lines, -9 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/history_menu_cocoa_controller.mm	View		2 chunks	+8 lines, -2 lines	0 comments	Download

Trybot results:

Total messages: 4 (0 generated)

pink

lgtm. is this just something we're going to have to keep an eye on as ...

4 years, 12 months ago (2010-06-04 13:00:26 UTC) #2

Robert Sesek

On 2010/06/04 13:00:26, pink wrote: > lgtm. is this just something we're going to have ...

4 years, 12 months ago (2010-06-04 19:12:55 UTC) #3

lgtm