Chromium Code Reviews
Help | Chromium Project | Sign in
(114)

Issue 2605006: [Mac] Disable menu certain menu items when a modal dialog or sheet is present. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 12 months ago by Robert Sesek
Modified:
4 years ago
Reviewers:
pink
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

[Mac] Disable menu certain menu items when a modal dialog or sheet is present. BUG=28755, 41818 TEST=Chromium-->Clear Browsing Data. Cannot open NTP. Cannot open bookmark manager. Cannot open history. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48964

Patch Set 1 #

Patch Set 2 : 80cols #

Patch Set 3 : nit #

Total comments: 1

Patch Set 4 : '' #

Patch Set 5 : Remove confusion (or add more?) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -12 lines) Patch
M chrome/browser/app_controller_mac.h View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 2 3 4 3 chunks +24 lines, -9 lines 0 comments Download
M chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/cocoa/history_menu_cocoa_controller.mm View 2 chunks +8 lines, -2 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
Robert Sesek
4 years, 12 months ago (2010-06-03 21:20:10 UTC) #1
pink
lgtm. is this just something we're going to have to keep an eye on as ...
4 years, 12 months ago (2010-06-04 13:00:26 UTC) #2
Robert Sesek
On 2010/06/04 13:00:26, pink wrote: > lgtm. is this just something we're going to have ...
4 years, 12 months ago (2010-06-04 19:12:55 UTC) #3
pink
4 years, 12 months ago (2010-06-04 20:06:11 UTC) #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be