Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 2604973002: Move computation of 3D descendants to the descendant-dependent flags walk. (Closed)
Patch Set: none Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayer.h
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.h b/third_party/WebKit/Source/core/paint/PaintLayer.h
index 5ec98e30761b2a55ff07149430cb6383269da79b..06de19648f7ca2a4747b4c7d5755619538ca6491 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.h
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.h
@@ -967,11 +967,8 @@ class CORE_EXPORT PaintLayer : public DisplayItemClient {
}
void clearClipRectsCache() const { m_clipRectsCache.reset(); }
- void dirty3DTransformedDescendantStatus();
- // Both updates the status, and returns true if descendants of this have 3d.
- bool update3DTransformedDescendantStatus();
bool has3DTransformedDescendant() const {
- DCHECK(!m_is3DTransformedDescendantDirty);
+ DCHECK(!m_needsDescendantDependentFlagsUpdate);
return m_has3DTransformedDescendant;
}
@@ -982,6 +979,8 @@ class CORE_EXPORT PaintLayer : public DisplayItemClient {
private:
void setNeedsCompositingInputsUpdateInternal();
+ void update3DTransformedDescendantStatus();
+
// Bounding box in the coordinates of this layer.
LayoutRect logicalBoundingBox() const;
@@ -1139,7 +1138,6 @@ class CORE_EXPORT PaintLayer : public DisplayItemClient {
unsigned m_needsPositionUpdate : 1;
#endif
- unsigned m_is3DTransformedDescendantDirty : 1;
// Set on a stacking context layer that has 3D descendants anywhere
// in a preserves3D hierarchy. Hint to do 3D-aware hit testing.
unsigned m_has3DTransformedDescendant : 1;

Powered by Google App Engine
This is Rietveld 408576698