Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js

Issue 2604883002: DevTools: namespace globals (Closed)
Patch Set: address CL feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js b/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
index e65892c1dff026350b2faf24efdb4e01c7a9fe32..99e46546a0beff60193852d0a43a369db5af30a7 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
@@ -29,7 +29,7 @@
/**
* @unrestricted
*/
-var TreeOutline = class extends Common.Object {
+UI.TreeOutline = class extends Common.Object {
/**
* @param {boolean=} nonFocusable
*/
@@ -39,7 +39,7 @@ var TreeOutline = class extends Common.Object {
this.selectedTreeElement = null;
this.expandTreeElementsWhenArrowing = false;
- /** @type {?function(!TreeElement, !TreeElement):number} */
+ /** @type {?function(!UI.TreeElement, !UI.TreeElement):number} */
this._comparator = null;
this.contentElement = this._rootElement._childrenListNode;
@@ -53,7 +53,7 @@ var TreeOutline = class extends Common.Object {
/**
* @param {boolean} isFocused
- * @this {TreeOutline}
+ * @this {UI.TreeOutline}
*/
function setFocused(isFocused) {
this._focused = isFocused;
@@ -63,7 +63,7 @@ var TreeOutline = class extends Common.Object {
}
_createRootElement() {
- this._rootElement = new TreeElement();
+ this._rootElement = new UI.TreeElement();
this._rootElement.treeOutline = this;
this._rootElement.root = true;
this._rootElement.selectable = false;
@@ -72,28 +72,28 @@ var TreeOutline = class extends Common.Object {
}
/**
- * @return {!TreeElement}
+ * @return {!UI.TreeElement}
*/
rootElement() {
return this._rootElement;
}
/**
- * @return {?TreeElement}
+ * @return {?UI.TreeElement}
*/
firstChild() {
return this._rootElement.firstChild();
}
/**
- * @param {!TreeElement} child
+ * @param {!UI.TreeElement} child
*/
appendChild(child) {
this._rootElement.appendChild(child);
}
/**
- * @param {!TreeElement} child
+ * @param {!UI.TreeElement} child
* @param {number} index
*/
insertChild(child, index) {
@@ -101,7 +101,7 @@ var TreeOutline = class extends Common.Object {
}
/**
- * @param {!TreeElement} child
+ * @param {!UI.TreeElement} child
*/
removeChild(child) {
this._rootElement.removeChild(child);
@@ -114,7 +114,7 @@ var TreeOutline = class extends Common.Object {
/**
* @param {number} x
* @param {number} y
- * @return {?TreeElement}
+ * @return {?UI.TreeElement}
*/
treeElementFromPoint(x, y) {
var node = this.contentElement.ownerDocument.deepElementFromPoint(x, y);
@@ -129,14 +129,14 @@ var TreeOutline = class extends Common.Object {
/**
* @param {?Event} event
- * @return {?TreeElement}
+ * @return {?UI.TreeElement}
*/
treeElementFromEvent(event) {
return event ? this.treeElementFromPoint(event.pageX, event.pageY) : null;
}
/**
- * @param {?function(!TreeElement, !TreeElement):number} comparator
+ * @param {?function(!UI.TreeElement, !UI.TreeElement):number} comparator
*/
setComparator(comparator) {
this._comparator = comparator;
@@ -157,7 +157,7 @@ var TreeOutline = class extends Common.Object {
}
/**
- * @param {!TreeElement} element
+ * @param {!UI.TreeElement} element
*/
_bindTreeElement(element) {
if (element.treeOutline)
@@ -167,7 +167,7 @@ var TreeOutline = class extends Common.Object {
}
/**
- * @param {!TreeElement} element
+ * @param {!UI.TreeElement} element
*/
_unbindTreeElement(element) {
if (!element.treeOutline)
@@ -245,7 +245,7 @@ var TreeOutline = class extends Common.Object {
}
/**
- * @param {!TreeElement} treeElement
+ * @param {!UI.TreeElement} treeElement
* @param {boolean} center
*/
_deferredScrollIntoView(treeElement, center) {
@@ -254,7 +254,7 @@ var TreeOutline = class extends Common.Object {
this._treeElementToScrollIntoView = treeElement;
this._centerUponScrollIntoView = center;
/**
- * @this {TreeOutline}
+ * @this {UI.TreeOutline}
*/
function deferredScrollIntoView() {
this._treeElementToScrollIntoView.listItemElement.scrollIntoViewIfNeeded(this._centerUponScrollIntoView);
@@ -265,7 +265,7 @@ var TreeOutline = class extends Common.Object {
};
/** @enum {symbol} */
-TreeOutline.Events = {
+UI.TreeOutline.Events = {
ElementAttached: Symbol('ElementAttached'),
ElementExpanded: Symbol('ElementExpanded'),
ElementCollapsed: Symbol('ElementCollapsed'),
@@ -275,7 +275,7 @@ TreeOutline.Events = {
/**
* @unrestricted
*/
-var TreeOutlineInShadow = class extends TreeOutline {
+UI.TreeOutlineInShadow = class extends UI.TreeOutline {
constructor() {
super();
this.contentElement.classList.add('tree-outline');
@@ -307,13 +307,13 @@ var TreeOutlineInShadow = class extends TreeOutline {
/**
* @unrestricted
*/
-var TreeElement = class {
+UI.TreeElement = class {
/**
* @param {(string|!Node)=} title
* @param {boolean=} expandable
*/
constructor(title, expandable) {
- /** @type {?TreeOutline} */
+ /** @type {?UI.TreeOutline} */
this.treeOutline = null;
this.parent = null;
this.previousSibling = null;
@@ -341,7 +341,7 @@ var TreeElement = class {
}
/**
- * @param {?TreeElement} ancestor
+ * @param {?UI.TreeElement} ancestor
* @return {boolean}
*/
hasAncestor(ancestor) {
@@ -359,7 +359,7 @@ var TreeElement = class {
}
/**
- * @param {?TreeElement} ancestor
+ * @param {?UI.TreeElement} ancestor
* @return {boolean}
*/
hasAncestorOrSelf(ancestor) {
@@ -367,7 +367,7 @@ var TreeElement = class {
}
/**
- * @return {!Array.<!TreeElement>}
+ * @return {!Array.<!UI.TreeElement>}
*/
children() {
return this._children || [];
@@ -381,14 +381,14 @@ var TreeElement = class {
}
/**
- * @return {?TreeElement}
+ * @return {?UI.TreeElement}
*/
firstChild() {
return this._children ? this._children[0] : null;
}
/**
- * @return {?TreeElement}
+ * @return {?UI.TreeElement}
*/
lastChild() {
return this._children ? this._children[this._children.length - 1] : null;
@@ -396,14 +396,14 @@ var TreeElement = class {
/**
* @param {number} index
- * @return {?TreeElement}
+ * @return {?UI.TreeElement}
*/
childAt(index) {
return this._children ? this._children[index] : null;
}
/**
- * @param {!TreeElement} child
+ * @param {!UI.TreeElement} child
* @return {number}
*/
indexOfChild(child) {
@@ -411,7 +411,7 @@ var TreeElement = class {
}
/**
- * @param {!TreeElement} child
+ * @param {!UI.TreeElement} child
*/
appendChild(child) {
if (!this._children)
@@ -426,7 +426,7 @@ var TreeElement = class {
}
/**
- * @param {!TreeElement} child
+ * @param {!UI.TreeElement} child
* @param {number} index
*/
insertChild(child, index) {
@@ -468,7 +468,7 @@ var TreeElement = class {
child.onattach();
child._ensureSelection();
if (this.treeOutline)
- this.treeOutline.dispatchEventToListeners(TreeOutline.Events.ElementAttached, child);
+ this.treeOutline.dispatchEventToListeners(UI.TreeOutline.Events.ElementAttached, child);
var nextSibling = child.nextSibling ? child.nextSibling._listItemNode : null;
this._childrenListNode.insertBefore(child._listItemNode, nextSibling);
this._childrenListNode.insertBefore(child._childrenListNode, nextSibling);
@@ -515,7 +515,7 @@ var TreeElement = class {
}
/**
- * @param {!TreeElement} child
+ * @param {!UI.TreeElement} child
*/
removeChild(child) {
if (!child)
@@ -833,7 +833,7 @@ var TreeElement = class {
this.expanded = false;
this.oncollapse();
if (this.treeOutline)
- this.treeOutline.dispatchEventToListeners(TreeOutline.Events.ElementCollapsed, this);
+ this.treeOutline.dispatchEventToListeners(UI.TreeOutline.Events.ElementCollapsed, this);
}
collapseRecursively() {
@@ -861,7 +861,7 @@ var TreeElement = class {
if (this.treeOutline) {
this.onexpand();
- this.treeOutline.dispatchEventToListeners(TreeOutline.Events.ElementExpanded, this);
+ this.treeOutline.dispatchEventToListeners(UI.TreeOutline.Events.ElementExpanded, this);
}
}
@@ -1010,7 +1010,7 @@ var TreeElement = class {
this.treeOutline.selectedTreeElement = this;
this._listItemNode.classList.add('selected');
this._setFocused(this.treeOutline._focused);
- this.treeOutline.dispatchEventToListeners(TreeOutline.Events.ElementSelected, this);
+ this.treeOutline.dispatchEventToListeners(UI.TreeOutline.Events.ElementSelected, this);
return this.onselect(selectedByUser);
}
@@ -1100,10 +1100,10 @@ var TreeElement = class {
/**
* @param {boolean} skipUnrevealed
- * @param {?TreeElement=} stayWithin
+ * @param {?UI.TreeElement=} stayWithin
* @param {boolean=} dontPopulate
* @param {!Object=} info
- * @return {?TreeElement}
+ * @return {?UI.TreeElement}
*/
traverseNextTreeElement(skipUnrevealed, stayWithin, dontPopulate, info) {
if (!dontPopulate)
@@ -1144,7 +1144,7 @@ var TreeElement = class {
/**
* @param {boolean} skipUnrevealed
* @param {boolean=} dontPopulate
- * @return {?TreeElement}
+ * @return {?UI.TreeElement}
*/
traversePreviousTreeElement(skipUnrevealed, dontPopulate) {
var element = skipUnrevealed ? (this.revealed() ? this.previousSibling : null) : this.previousSibling;
@@ -1178,9 +1178,9 @@ var TreeElement = class {
console.assert(paddingLeftValue.endsWith('px'));
var computedLeftPadding = parseFloat(paddingLeftValue);
var left = this._listItemNode.totalOffsetLeft() + computedLeftPadding;
- return event.pageX >= left && event.pageX <= left + TreeElement._ArrowToggleWidth && this._expandable;
+ return event.pageX >= left && event.pageX <= left + UI.TreeElement._ArrowToggleWidth && this._expandable;
}
};
/** @const */
-TreeElement._ArrowToggleWidth = 10;
+UI.TreeElement._ArrowToggleWidth = 10;
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js ('k') | third_party/WebKit/Source/devtools/scripts/namespaces.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698