third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js - Issue 2604883002: DevTools: namespace globals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

Issue 2604883002: DevTools: namespace globals (Closed)

Patch Set: address CL feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js b/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

index 11709408771d514e9d104e0ce66f0d0ff0772d85..df8ff2885b80a70cd6fb04074c8990b75bf2cd1d 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

@@ -898,7 +898,7 @@ UI.ToolbarCheckbox = class extends UI.ToolbarItem {

* @param {function()=} listener

constructor(text, title, setting, listener) {

- super(createCheckboxLabel(text));

+ super(UI.createCheckboxLabel(text));

this.element.classList.add('checkbox');

this.inputElement = this.element.checkboxElement;

if (title)