third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js - Issue 2604883002: DevTools: namespace globals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

Issue 2604883002: DevTools: namespace globals (Closed)

Patch Set: address CL feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

index f7d11a55d120c0377ec6e894ca4b2f3e05b11608..3e7d8520348384ddfd441967052adfaa6fa5c7c8 100644

--- a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

+++ b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

@@ -313,7 +313,7 @@ Resources.ServiceWorkersView.Section = class {

this._section.setFieldVisible(Common.UIString('Errors'), !!this._registration.errors.length);

var errorsValue = this._wrapWidget(this._section.appendField(Common.UIString('Errors')));

- var errorsLabel = createLabel(String(this._registration.errors.length), 'smallicon-error');

+ var errorsLabel = UI.createLabel(String(this._registration.errors.length), 'smallicon-error');

errorsLabel.classList.add('service-worker-errors-label');

errorsValue.appendChild(errorsLabel);

this._moreButton = createLink(

@@ -346,7 +346,7 @@ Resources.ServiceWorkersView.Section = class {

if (this._errorsList.childElementCount > 100)

this._errorsList.firstElementChild.remove();

message.appendChild(this._linkifier.linkifyScriptLocation(target, null, error.sourceURL, error.lineNumber));

- message.appendChild(createLabel('#' + error.versionId + ': ' + error.errorMessage, 'smallicon-error'));

+ message.appendChild(UI.createLabel('#' + error.versionId + ': ' + error.errorMessage, 'smallicon-error'));

}

/**