third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js - Issue 2604883002: DevTools: namespace globals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

Issue 2604883002: DevTools: namespace globals (Closed)

Patch Set: address CL feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js b/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

index c99bed20ca50929251404344ea51f66a0b746397..4e0749e0363a5a263db8bfc6db3dd16d910ffb91 100644

--- a/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

+++ b/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

@@ -86,7 +86,7 @@ Resources.AppManifestView = class extends UI.VBox {

this._errorsSection.element.classList.toggle('hidden', !errors.length);

for (var error of errors) {

this._errorsSection.appendRow().appendChild(

- createLabel(error.message, error.critical ? 'smallicon-error' : 'smallicon-warning'));

+ UI.createLabel(error.message, error.critical ? 'smallicon-error' : 'smallicon-warning'));

}

if (!data)