Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js

Issue 2604883002: DevTools: namespace globals (Closed)
Patch Set: address CL feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
index b6421d13764af46850078639a02bab83d1eda8eb..cfd28b059a1774fad10adc12fb6feb881868a08e 100644
--- a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
+++ b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
@@ -50,10 +50,10 @@ Profiler.ProfileLauncherView = class extends UI.VBox {
selectTargetText.textContent = Common.UIString('Target:');
var targetsSelect = targetSpan.createChild('select', 'chrome-select');
new Profiler.TargetsComboBoxController(targetsSelect, targetSpan);
- this._controlButton = createTextButton('', this._controlButtonClicked.bind(this), 'control-profiling');
+ this._controlButton = UI.createTextButton('', this._controlButtonClicked.bind(this), 'control-profiling');
this._contentElement.appendChild(this._controlButton);
this._recordButtonEnabled = true;
- this._loadButton = createTextButton(Common.UIString('Load'), this._loadButtonClicked.bind(this), 'load-profile');
+ this._loadButton = UI.createTextButton(Common.UIString('Load'), this._loadButtonClicked.bind(this), 'load-profile');
this._contentElement.appendChild(this._loadButton);
SDK.targetManager.observeTargets(this);
}
@@ -173,7 +173,7 @@ Profiler.MultiProfileLauncherView = class extends Profiler.ProfileLauncherView {
* @param {!Profiler.ProfileType} profileType
*/
addProfileType(profileType) {
- var labelElement = createRadioLabel('profile-type', profileType.name);
+ var labelElement = UI.createRadioLabel('profile-type', profileType.name);
this._profileTypeSelectorForm.appendChild(labelElement);
var optionElement = labelElement.radioElement;
this._typeIdToOptionElement[profileType.id] = optionElement;

Powered by Google App Engine
This is Rietveld 408576698