third_party/WebKit/Source/devtools/front_end/network/NetworkManageCustomHeadersView.js - Issue 2604883002: DevTools: namespace globals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkManageCustomHeadersView.js

Issue 2604883002: DevTools: namespace globals (Closed)

Patch Set: address CL feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js ('k') | third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkManageCustomHeadersView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkManageCustomHeadersView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkManageCustomHeadersView.js

index a85253b10a107091ca4221b15e3a7429b615c79e..b46f0c1deeaf24efe248ef23f4225e134589854c 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkManageCustomHeadersView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkManageCustomHeadersView.js

@@ -29,8 +29,8 @@ Network.NetworkManageCustomHeadersView = class extends UI.VBox {

placeholder.textContent = Common.UIString('No custom headers');

this._list.setEmptyPlaceholder(placeholder);

this._list.show(this.contentElement);

- this.contentElement.appendChild(

- createTextButton(Common.UIString('Add custom header\u2026'), this._addButtonClicked.bind(this), 'add-button'));

+ this.contentElement.appendChild(UI.createTextButton(

+ Common.UIString('Add custom header\u2026'), this._addButtonClicked.bind(this), 'add-button'));

/** @type {!Map.<string, !{title: string, editable: boolean}>} */

this._columnConfigs = new Map();