third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js - Issue 2604883002: DevTools: namespace globals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js

Issue 2604883002: DevTools: namespace globals (Closed)

Patch Set: address CL feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js b/third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js

index 7ab55da07e40fa6120e6f4eb5995f03ecdf7a794..2312000f638998c4aaa5c99b21b6282f7bffc63e 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js

@@ -18,7 +18,8 @@ Emulation.DevicesSettingsTab = class extends UI.VBox {

.createChild('div', 'settings-tab help-content help-container');

var buttonsRow = this.containerElement.createChild('div', 'devices-button-row');

- this._addCustomButton = createTextButton(Common.UIString('Add custom device...'), this._addCustomDevice.bind(this));

+ this._addCustomButton =

+ UI.createTextButton(Common.UIString('Add custom device...'), this._addCustomDevice.bind(this));

buttonsRow.appendChild(this._addCustomButton);

this._list = new UI.ListWidget(this);