third_party/WebKit/Source/devtools/front_end/elements/PropertiesWidget.js - Issue 2604883002: DevTools: namespace globals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/PropertiesWidget.js

Issue 2604883002: DevTools: namespace globals (Closed)

Patch Set: address CL feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/PropertiesWidget.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/PropertiesWidget.js b/third_party/WebKit/Source/devtools/front_end/elements/PropertiesWidget.js

index d9389b7ef551db6e79afdde81d54cf9cabaf1461..1bf84cd68234fc5ea1ddaa76406a6808b8c1df99 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/PropertiesWidget.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/PropertiesWidget.js

@@ -143,7 +143,7 @@ Elements.PropertiesWidget = class extends UI.ThrottledWidget {

this.element.appendChild(section.element);

if (expanded[this.sections.length - 1])

section.expand();

- section.addEventListener(TreeOutline.Events.ElementExpanded, this._propertyExpanded, this);

+ section.addEventListener(UI.TreeOutline.Events.ElementExpanded, this._propertyExpanded, this);

}

@@ -154,7 +154,7 @@ Elements.PropertiesWidget = class extends UI.ThrottledWidget {

_propertyExpanded(event) {

Host.userMetrics.actionTaken(Host.UserMetrics.Action.DOMPropertiesExpanded);

for (var section of this.sections)

- section.removeEventListener(TreeOutline.Events.ElementExpanded, this._propertyExpanded, this);

+ section.removeEventListener(UI.TreeOutline.Events.ElementExpanded, this._propertyExpanded, this);

}

/**